From 54aa98693e12df547fdeb692f9ae4e132ad73217 Mon Sep 17 00:00:00 2001 From: Jeremy Ruppel Date: Fri, 11 Sep 2026 20:43:11 +0000 Subject: [PATCH] chore: enable oxlint media-has-caption rule Enable the jsx-a11y media-has-caption rule in oxlint and make oxlint the sole enforcer by turning off Biome's useMediaCaption. Migrate the one existing suppression from a biome-ignore to an oxlint-disable comment. --- biome.jsonc | 1 + site/.oxlintrc.jsonc | 2 +- site/src/pages/AgentsPage/components/VideoLightbox.tsx | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/biome.jsonc b/biome.jsonc index 4a255bf9e0caf..aff3f78097fb5 100644 --- a/biome.jsonc +++ b/biome.jsonc @@ -15,6 +15,7 @@ "linter": { "rules": { "a11y": { + "useMediaCaption": "off", // oxlint owns media-has-caption "noSvgWithoutTitle": "off", "useButtonType": "off", "useSemanticElements": "off", diff --git a/site/.oxlintrc.jsonc b/site/.oxlintrc.jsonc index b8f9897414ae8..f4cedfa778322 100644 --- a/site/.oxlintrc.jsonc +++ b/site/.oxlintrc.jsonc @@ -35,6 +35,7 @@ "autocomplete-valid": "error", "html-has-lang": "error", "lang": "error", + "media-has-caption": "error", // --- complexity --- "no-regex-spaces": "error", @@ -213,7 +214,6 @@ "no-empty-interface": "off", // suspicious/noEmptyInterface (small) "no-danger": "off", // security/noDangerouslySetInnerHtml (small: Biome suppression to migrate) "no-noninteractive-tabindex": "off", // a11y/noNoninteractiveTabindex (small) - "media-has-caption": "off", // a11y/useMediaCaption (small) "interactive-supports-focus": "off", // a11y/useFocusableInteractive (small) "iframe-has-title": "off", // a11y/useIframeTitle (small) "prefer-template": "off", // style/useTemplate (small) diff --git a/site/src/pages/AgentsPage/components/VideoLightbox.tsx b/site/src/pages/AgentsPage/components/VideoLightbox.tsx index 28e75c1461f85..4132016027382 100644 --- a/site/src/pages/AgentsPage/components/VideoLightbox.tsx +++ b/site/src/pages/AgentsPage/components/VideoLightbox.tsx @@ -27,7 +27,7 @@ export const VideoLightbox: FC = ({ {RECORDING_UNAVAILABLE_TEXT} ) : ( - // biome-ignore lint/a11y/useMediaCaption: Screen recordings do not have caption tracks. + // oxlint-disable-next-line jsx-a11y/media-has-caption -- Screen recordings do not have caption tracks.