Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Unify context usage for agent cmd and logs #5059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix: Unify context usage for agent cmd and logs #5059

merged 1 commit into from
Nov 14, 2022

Conversation

mafredri
Copy link
Member

  • Fix logs using context.Background()
  • Use new ctx instead of command.Context() so that context changes in the future are propagated

Bonus:

  • Fix access of a.network outside mutex

@mafredri mafredri self-assigned this Nov 14, 2022
mtojek
mtojek approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mafredri mafredri merged commit c515085 into main Nov 14, 2022
@mafredri mafredri deleted the mafredri/agent-context-fixes branch November 14, 2022 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @mtojek