fix!: enforce unique agent names per workspace #5497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Progresses #5347? |
coadler
approved these changes
Dec 22, 2022
mafredri
approved these changes
Dec 22, 2022
|
Yes it would prevent existing templates from starting if they were incorrect templates. The fix is easy though and the error message is clear as to what the error is so it should be easy for affected users to resolve. |
|
Running workspaces are fine though |
|
Sounds good 👍🏻. Considering that, should we mark this as a breaking change? |
|
Sure I guess, feel free to mark it |
|
@ghuntley this does not progress that PR, not related to usernames just agent names |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only implemented in Go because writing a constraint would be difficult as the only way to check if an agent name is conflicting is by checking 3 different tables for information. Constraints don't support that, so we'd have to write a trigger. This is also how we do app name unique-per-workspace constraints because of the same problem.
I think this is good enough. Coder doesn't crash or have massively bad behavior if multiple agents share a name, it just will pick one instead of the other when doing operations by name.