From ea7cb887a16e0e1a7508cac2a07c4ad0e988abaa Mon Sep 17 00:00:00 2001
From: Kyle Carberry <kyle@carberry.com>
Date: Wed, 18 Jan 2023 21:53:41 +0000
Subject: [PATCH] fix: improve error handling when posting workspace agent
 version

A customer ran into an unfortunate error here that we miss!
---
 codersdk/workspaceagents.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/codersdk/workspaceagents.go b/codersdk/workspaceagents.go
index bb8ce62406f12..93ac907ab445e 100644
--- a/codersdk/workspaceagents.go
+++ b/codersdk/workspaceagents.go
@@ -489,15 +489,15 @@ func (c *Client) PostWorkspaceAgentAppHealth(ctx context.Context, req PostWorksp
 }
 
 func (c *Client) PostWorkspaceAgentVersion(ctx context.Context, version string) error {
-	// Phone home and tell the mothership what version we're on.
 	versionReq := PostWorkspaceAgentVersionRequest{Version: version}
 	res, err := c.Request(ctx, http.MethodPost, "/api/v2/workspaceagents/me/version", versionReq)
 	if err != nil {
+		return err
+	}
+	defer res.Body.Close()
+	if res.StatusCode != http.StatusOK {
 		return readBodyAsError(res)
 	}
-	// Discord the response
-	_, _ = io.Copy(io.Discard, res.Body)
-	_ = res.Body.Close()
 	return nil
 }