From 6785b9f5ff74d6a3750daceb94ee260539b0ded5 Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Thu, 6 Apr 2023 17:10:32 +0000 Subject: [PATCH] chore: de-flake TestWorkspaceAgent_Metadata --- coderd/workspaceagents_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/coderd/workspaceagents_test.go b/coderd/workspaceagents_test.go index dc38b99242574..72508a98e0e96 100644 --- a/coderd/workspaceagents_test.go +++ b/coderd/workspaceagents_test.go @@ -1353,9 +1353,13 @@ func TestWorkspaceAgent_Metadata(t *testing.T) { var update []codersdk.WorkspaceAgentMetadata check := func(want codersdk.WorkspaceAgentMetadataResult, got codersdk.WorkspaceAgentMetadata) { - require.WithinDuration(t, want.CollectedAt, got.Result.CollectedAt, time.Second) + require.Greater(t, got.Result.CollectedAt, want.CollectedAt) + + ageImpliedNow := got.Result.CollectedAt.Add(time.Duration(got.Result.Age) * time.Second) + // We use a long WithinDuration to tolerate slow CI, but we're still making sure + // that Age is within the ballpark. require.WithinDuration( - t, time.Now(), got.Result.CollectedAt.Add(time.Duration(got.Result.Age)*time.Second), time.Second, + t, time.Now(), ageImpliedNow, time.Second*10, ) require.Equal(t, want.Value, got.Result.Value) require.Equal(t, want.Error, got.Result.Error)