From 8a8d3b221745e804b7d9e4583e3c641de8b73826 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Mon, 17 Apr 2023 17:27:32 +0000 Subject: [PATCH] test(agent/reaper): Fix restructure issue In #7164 we accidentally removed the "in CI" check, this fixes it. --- agent/reaper/reaper_test.go | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/agent/reaper/reaper_test.go b/agent/reaper/reaper_test.go index ed45f1e8c9b12..0509edb382c6b 100644 --- a/agent/reaper/reaper_test.go +++ b/agent/reaper/reaper_test.go @@ -18,7 +18,11 @@ import ( "github.com/coder/coder/testutil" ) -//nolint:paralleltest // Non-parallel subtest. +// TestReap checks that's the reaper is successfully reaping +// exited processes and passing the PIDs through the shared +// channel. +// +//nolint:paralleltest func TestReap(t *testing.T) { // Don't run the reaper test in CI. It does weird // things like forkexecing which may have unintended @@ -27,13 +31,6 @@ func TestReap(t *testing.T) { t.Skip("Detected CI, skipping reaper tests") } - // OK checks that's the reaper is successfully reaping - // exited processes and passing the PIDs through the shared - // channel. -} - -//nolint:paralleltest // Signal handling. -func TestReap_OK(t *testing.T) { pids := make(reap.PidCh, 1) err := reaper.ForkReap( reaper.WithPIDCallback(pids),