fix: set network extension as unconfigured when system extension is deleted (#162)

ethanndickson · web-flow · commit 9f356e55dab8 · 2025-05-16T15:38:43.000+10:00
This fixes a bug when `Launch Coder Connect at startup` is enabled when updating the app with #161, where the app attempts to start too early, as it thinks the VPN is configured, but it was unconfigured with the deletion of the system extension.
diff --git a/Coder-Desktop/Coder-Desktop/VPN/VPNSystemExtension.swift b/Coder-Desktop/Coder-Desktop/VPN/VPNSystemExtension.swift
@@ -63,6 +63,10 @@ extension CoderVPNService: SystemExtensionAsyncRecorder {
             // system extension was successfully installed, so we don't need the delegate any more
             systemExtnDelegate = nil
         }
+        if state == .uninstalled {
+            // System extension was deleted, and the VPN configurations go with it
+            neState = .unconfigured
+        }
     }
 
     func installSystemExtension() {

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,10 @@ extension CoderVPNService: SystemExtensionAsyncRecorder {`
`63`	`63`	`// system extension was successfully installed, so we don't need the delegate any more`
`64`	`64`	`systemExtnDelegate = nil`
`65`	`65`	`}`
	`66`	`+ if state == .uninstalled {`
	`67`	`+ // System extension was deleted, and the VPN configurations go with it`
	`68`	`+ neState = .unconfigured`
	`69`	`+ }`
`66`	`70`	`}`
`67`	`71`
`68`	`72`	`func installSystemExtension() {`