chore: dont stop coder connect on device sleep (#151)

ethanndickson · web-flow · commit f03952665be3 · 2025-05-08T13:35:39.000+10:00
Closes #88. With coder/internal#563 resolved, there's no need to stop the VPN on sleep, as when the device wakes the tunnel will have the correct workspace & agent state. However, if the Coder deployment doesn't include the patch in coder/coder#17598 (presumably v2.23 or later), the UI state will go out of sync when the device is slept or internet connection is lost. I think this is fine honestly, and I don't think it's worth doing a server version check to determine whether we should stop the VPN on sleep.
diff --git a/Coder-Desktop/VPN/Manager.swift b/Coder-Desktop/VPN/Manager.swift
@@ -32,10 +32,9 @@ actor Manager {
             let sessionConfig = URLSessionConfiguration.default
             // The tunnel might be asked to start before the network interfaces have woken up from sleep
             sessionConfig.waitsForConnectivity = true
-            // URLSession's waiting for connectivity sometimes hangs even when
-            // the network is up so this is deliberately short (30s) to avoid a
-            // poor UX where it appears stuck.
-            sessionConfig.timeoutIntervalForResource = 30
+            // Timeout after 5 minutes, or if there's no data for 60 seconds
+            sessionConfig.timeoutIntervalForRequest = 60
+            sessionConfig.timeoutIntervalForResource = 300
             try await download(src: dylibPath, dest: dest, urlSession: URLSession(configuration: sessionConfig))
         } catch {
             throw .download(error)
diff --git a/Coder-Desktop/VPN/PacketTunnelProvider.swift b/Coder-Desktop/VPN/PacketTunnelProvider.swift
@@ -57,7 +57,7 @@ class PacketTunnelProvider: NEPacketTunnelProvider, @unchecked Sendable {
         start(completionHandler)
     }
 
-    // called by `startTunnel` and on `wake`
+    // called by `startTunnel`
     func start(_ completionHandler: @escaping (Error?) -> Void) {
         guard let proto = protocolConfiguration as? NETunnelProviderProtocol,
               let baseAccessURL = proto.serverAddress
@@ -108,7 +108,7 @@ class PacketTunnelProvider: NEPacketTunnelProvider, @unchecked Sendable {
         teardown(completionHandler)
     }
 
-    // called by `stopTunnel` and `sleep`
+    // called by `stopTunnel`
     func teardown(_ completionHandler: @escaping () -> Void) {
         guard let manager else {
             logger.error("teardown called with nil Manager")
@@ -138,34 +138,6 @@ class PacketTunnelProvider: NEPacketTunnelProvider, @unchecked Sendable {
         }
     }
 
-    // sleep and wake reference: https://developer.apple.com/forums/thread/95988
-    override func sleep(completionHandler: @escaping () -> Void) {
-        logger.debug("sleep called")
-        teardown(completionHandler)
-    }
-
-    override func wake() {
-        // It's possible the tunnel is still starting up, if it is, wake should
-        // be a no-op.
-        guard !reasserting else { return }
-        guard manager == nil else {
-            logger.error("wake called with non-nil Manager")
-            return
-        }
-        logger.debug("wake called")
-        reasserting = true
-        currentSettings = .init(tunnelRemoteAddress: "127.0.0.1")
-        setTunnelNetworkSettings(nil)
-        start { error in
-            if let error {
-                self.logger.error("error starting tunnel after wake: \(error.localizedDescription)")
-                self.cancelTunnelWithError(error)
-            } else {
-                self.reasserting = false
-            }
-        }
-    }
-
     // Wrapper around `setTunnelNetworkSettings` that supports merging updates
     func applyTunnelNetworkSettings(_ diff: Vpn_NetworkSettingsRequest) async throws {
         logger.debug("applying settings diff: \(diff.debugDescription, privacy: .public)")
