Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: set minimum coder server version to v2.24.3 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

chore: set minimum coder server version to v2.24.3 #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Coder-Desktop/Coder-DesktopTests/LoginFormTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import Mocker
import SwiftUI
import Testing
import ViewInspector
@testable import VPNLib

@MainActor
@Suite(.timeLimit(.minutes(1)))
Expand Down Expand Up @@ -134,7 +135,7 @@ struct LoginTests {
username: "admin"
)
let buildInfo = BuildInfoResponse(
version: "v2.24.2"
version: "v\(Validator.minimumCoderVersion)"
)

try Mock(
Expand Down
3 changes: 1 addition & 2 deletions Coder-Desktop/VPNLib/Validate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ public enum ValidationError: Error {

public class Validator {
// This version of the app has a strict version requirement.
// TODO(ethanndickson): Set to 2.25.0
public static let minimumCoderVersion = "2.24.2"
public static let minimumCoderVersion = "2.24.3"

private static let expectedIdentifier = "com.coder.cli"
// The Coder team identifier
Expand Down
2 changes: 2 additions & 0 deletions Coder-Desktop/project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,8 @@ targets:
- target: "Coder Desktop"
- target: CoderSDK
embed: false # Do not embed the framework.
- target: VPNLib
embed: false # Do not embed the framework.
- package: ViewInspector
- package: Mocker

Expand Down
Loading