display apps

deansheather · deansheather · commit 0306938be967 · 2025-05-08T15:28:44.000+10:00
diff --git a/App/ViewModels/AgentAppViewModel.cs b/App/ViewModels/AgentAppViewModel.cs
@@ -142,7 +142,6 @@ private void OpenApp(object parameter)
             var cred = _credentialManager.GetCachedCredentials();
             if (cred.State is CredentialState.Valid && cred.ApiToken is not null)
                 uriString = uriString.Replace(SessionTokenUriVar, cred.ApiToken);
-            uriString += SessionTokenUriVar;
             if (uriString.Contains(SessionTokenUriVar))
                 throw new Exception($"URI contains {SessionTokenUriVar} variable but could not be replaced");
 
diff --git a/App/ViewModels/AgentViewModel.cs b/App/ViewModels/AgentViewModel.cs
@@ -60,6 +60,11 @@ public partial class AgentViewModel : ObservableObject, IModelUpdateable<AgentVi
     private const string DefaultDashboardUrl = "https://coder.com";
     private const int MaxAppsPerRow = 6;
 
+    // These are fake UUIDs, for UI purposes only. Display apps don't exist on
+    // the backend as real app resources and therefore don't have an ID.
+    private static readonly Uuid VscodeAppUuid = new("819828b1-5213-4c3d-855e-1b74db6ddd19");
+    private static readonly Uuid VscodeInsidersAppUuid = new("becf1e10-5101-4940-a853-59af86468069");
+
     private readonly ILogger<AgentViewModel> _logger;
     private readonly ICoderApiClientFactory _coderApiClientFactory;
     private readonly ICredentialManager _credentialManager;
@@ -274,6 +279,32 @@ private void ContinueFetchApps(Task<WorkspaceAgent> task)
             apps.Add(_agentAppViewModelFactory.Create(uuid, app.DisplayName, app.Url, iconUrl));
         }
 
+        foreach (var displayApp in workspaceAgent.DisplayApps)
+        {
+            if (displayApp is not WorkspaceAgent.DisplayAppVscode and not WorkspaceAgent.DisplayAppVscodeInsiders)
+                continue;
+
+            var id = VscodeAppUuid;
+            var displayName = "VS Code";
+            var icon = "/icon/code.svg";
+            var scheme = "vscode";
+            if (displayApp is WorkspaceAgent.DisplayAppVscodeInsiders)
+            {
+                id = VscodeInsidersAppUuid;
+                displayName = "VS Code Insiders";
+                icon = "/icon/code-insiders.svg";
+                scheme = "vscode-insiders";
+            }
+
+            var appUri = $"{scheme}://vscode-remote/ssh-remote+{FullHostname}/{workspaceAgent.ExpandedDirectory}";
+
+            // Icon parse failures are not fatal, we will just use the fallback
+            // icon.
+            _ = Uri.TryCreate(DashboardBaseUrl, icon, out var iconUrl);
+
+            apps.Add(_agentAppViewModelFactory.Create(id, displayName, appUri, iconUrl));
+        }
+
         // Sort by name.
         ModelUpdate.ApplyLists(Apps, apps, (a, b) => string.Compare(a.Name, b.Name, StringComparison.Ordinal));
     }
diff --git a/CoderSdk/Coder/WorkspaceAgents.cs b/CoderSdk/Coder/WorkspaceAgents.cs
@@ -7,7 +7,16 @@ public partial interface ICoderApiClient
 
 public class WorkspaceAgent
 {
+    public const string DisplayAppVscode = "vscode";
+    public const string DisplayAppVscodeInsiders = "vscode_insiders";
+
+    public string ExpandedDirectory { get; set; } = "";
+
     public WorkspaceApp[] Apps { get; set; } = [];
+
+    // This isn't an enum to avoid future display apps breaking the desktop
+    // app.
+    public string[] DisplayApps { get; set; } = [];
 }
 
 public class WorkspaceApp
