fix various warnings

deansheather · deansheather · commit c6d45ea257cf · 2025-05-06T16:28:39.000+10:00
diff --git a/App/Controls/ExpandChevron.xaml b/App/Controls/ExpandChevron.xaml
@@ -17,7 +17,7 @@
             Height="16"
             Margin="0,0,8,0"
             RenderTransformOrigin="0.5, 0.5"
-            Foreground="{x:Bind Foreground, Mode=Oneway}"
+            Foreground="{x:Bind Foreground, Mode=OneWay}"
             HorizontalAlignment="Center"
             VerticalAlignment="Center"
             AnimatedIcon.State="NormalOff">
diff --git a/App/Controls/ExpandChevron.xaml.cs b/App/Controls/ExpandChevron.xaml.cs
@@ -1,11 +1,9 @@
 using DependencyPropertyGenerator;
 using Microsoft.UI.Xaml.Controls;
-using Microsoft.UI.Xaml.Media;
 
 namespace Coder.Desktop.App.Controls;
 
 [DependencyProperty<bool>("IsOpen", DefaultValue = false)]
-[DependencyProperty<SolidColorBrush>("Foreground")]
 public sealed partial class ExpandChevron : UserControl
 {
     public ExpandChevron()
diff --git a/App/Services/CredentialManager.cs b/App/Services/CredentialManager.cs
@@ -105,7 +105,7 @@ public CredentialModel GetCachedCredentials()
     public CoderApiClientCredential? GetCoderApiClientCredential()
     {
         var latestCreds = _latestCredentials;
-        if (latestCreds is not { State: CredentialState.Valid })
+        if (latestCreds is not { State: CredentialState.Valid } || latestCreds.CoderUrl is null)
             return null;
 
         return new CoderApiClientCredential
diff --git a/App/ViewModels/FileSyncListViewModel.cs b/App/ViewModels/FileSyncListViewModel.cs
@@ -339,7 +339,8 @@ public void OpenRemotePathSelectDialog()
         pickerViewModel.PathSelected += OnRemotePathSelected;
 
         _remotePickerWindow = new DirectoryPickerWindow(pickerViewModel);
-        _remotePickerWindow.SetParent(_window);
+        if (_window is not null)
+            _remotePickerWindow.SetParent(_window);
         _remotePickerWindow.Closed += (_, _) =>
         {
             _remotePickerWindow = null;
diff --git a/App/Views/Pages/SignInTokenPage.xaml b/App/Views/Pages/SignInTokenPage.xaml
@@ -86,14 +86,14 @@
             <Button
                 Content="Back" HorizontalAlignment="Right"
                 Command="{x:Bind ViewModel.TokenPage_BackCommand, Mode=OneWay}"
-                CommandParameter="{x:Bind SignInWindow, Mode=OneWay}" />
+                CommandParameter="{x:Bind SignInWindow}" />
 
             <Button
                 Content="Sign In"
                 HorizontalAlignment="Left"
                 Style="{StaticResource AccentButtonStyle}"
                 Command="{x:Bind ViewModel.TokenPage_SignInCommand, Mode=OneWay}"
-                CommandParameter="{x:Bind SignInWindow, Mode=OneWay}" />
+                CommandParameter="{x:Bind SignInWindow}" />
         </StackPanel>
     </StackPanel>
 </Page>
diff --git a/App/Views/Pages/SignInUrlPage.xaml b/App/Views/Pages/SignInUrlPage.xaml
@@ -61,7 +61,7 @@
             Content="Next"
             HorizontalAlignment="Center"
             Command="{x:Bind ViewModel.UrlPage_NextCommand, Mode=OneWay}"
-            CommandParameter="{x:Bind SignInWindow, Mode=OneWay}"
+            CommandParameter="{x:Bind SignInWindow}"
             Style="{StaticResource AccentButtonStyle}" />
     </StackPanel>
 </Page>

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public CredentialModel GetCachedCredentials()`
`105`	`105`	`public CoderApiClientCredential? GetCoderApiClientCredential()`
`106`	`106`	`{`
`107`	`107`	`var latestCreds = _latestCredentials;`
`108`		`- if (latestCreds is not { State: CredentialState.Valid })`
	`108`	`+ if (latestCreds is not { State: CredentialState.Valid } \|\| latestCreds.CoderUrl is null)`
`109`	`109`	`return null;`
`110`	`110`
`111`	`111`	`return new CoderApiClientCredential`
Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,8 @@ public void OpenRemotePathSelectDialog()`
`339`	`339`	`pickerViewModel.PathSelected += OnRemotePathSelected;`
`340`	`340`
`341`	`341`	`_remotePickerWindow = new DirectoryPickerWindow(pickerViewModel);`
`342`		`- _remotePickerWindow.SetParent(_window);`
	`342`	`+ if (_window is not null)`
	`343`	`+ _remotePickerWindow.SetParent(_window);`
`343`	`344`	`_remotePickerWindow.Closed += (_, _) =>`
`344`	`345`	`{`
`345`	`346`	`_remotePickerWindow = null;`