fix: don't store token when certificates are configured

fioan89 · fioan89 · commit 9f2a967967ac · 2025-09-13T00:34:52.000+03:00
This was a regression for the custom flows that required authentication via certificates,
the http client and the coder cli were properly initialized but afterward the token was
still required for storing.

Note: the issue was hard to catch early on because the official coder cli is not supporting auth. via certificates.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixed
+
+- token is no longer required when authentication is done via certificates
+
 ## 0.6.4 - 2025-09-03
 
 ### Added
diff --git a/src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt b/src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt
@@ -396,9 +396,13 @@ class CoderRemoteProvider(
     private fun onConnect(client: CoderRestClient, cli: CoderCLIManager) {
         // Store the URL and token for use next time.
         context.secrets.lastDeploymentURL = client.url.toString()
-        context.secrets.lastToken = client.token ?: ""
-        context.secrets.storeTokenFor(client.url, context.secrets.lastToken)
-        context.logger.info("Deployment URL and token were stored and will be available for automatic connection")
+        if (context.settingsStore.requireTokenAuth) {
+            context.secrets.lastToken = client.token ?: ""
+            context.secrets.storeTokenFor(client.url, context.secrets.lastToken)
+            context.logger.info("Deployment URL and token were stored and will be available for automatic connection")
+        } else {
+            context.logger.info("Deployment URL was stored and will be available for automatic connection")
+        }
         this.client = client
         pollJob?.let {
             it.cancel()
