fix: install the build number if available

fioan89 · fioan89 · commit e7acd539737b · 2025-06-18T00:25:14.000+03:00
This PR fixes an issue with URI handling which was not installing the
exact same version requested by the user if the version was available for
install on the workspace.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@
 - `Stop` action is now available for running workspaces that have an out of date template.
 - outdated and stopped workspaces are now updated and started when handling URI
 - show errors when the Toolbox is visible again after being minimized.
+- URI handling now installs the exact build number if it is available for the workspace.
 
 ## 0.3.0 - 2025-06-10
 
diff --git a/src/main/kotlin/com/coder/toolbox/util/CoderProtocolHandler.kt b/src/main/kotlin/com/coder/toolbox/util/CoderProtocolHandler.kt
@@ -380,16 +380,16 @@ open class CoderProtocolHandler(
             return null
         }
 
-        val matchingBuildNumber = availableVersions.firstOrNull { it.contains(buildNumber) } != null
-        if (!matchingBuildNumber) {
+        val buildNumberIsNotAvailable = availableVersions.firstOrNull { it.contains(buildNumber) } == null
+        if (buildNumberIsNotAvailable) {
             val selectedIde = availableVersions.maxOf { it }
             context.logAndShowInfo(
                 "$productCode-$buildNumber not available",
                 "$productCode-$buildNumber is not available, we've selected the latest $selectedIde"
             )
             return selectedIde
         }
-        return null
+        return "$productCode-$buildNumber"
     }
 
     private fun installJBClient(selectedIde: String, environmentId: String): Job = context.cs.launch {

Original file line number	Diff line number	Diff line change
`@@ -380,16 +380,16 @@ open class CoderProtocolHandler(`
`380`	`380`	`return null`
`381`	`381`	`}`
`382`	`382`
`383`		`- val matchingBuildNumber = availableVersions.firstOrNull { it.contains(buildNumber) } != null`
`384`		`- if (!matchingBuildNumber) {`
	`383`	`+ val buildNumberIsNotAvailable = availableVersions.firstOrNull { it.contains(buildNumber) } == null`
	`384`	`+ if (buildNumberIsNotAvailable) {`
`385`	`385`	`val selectedIde = availableVersions.maxOf { it }`
`386`	`386`	`context.logAndShowInfo(`
`387`	`387`	`"$productCode-$buildNumber not available",`
`388`	`388`	`"$productCode-$buildNumber is not available, we've selected the latest $selectedIde"`
`389`	`389`	`)`
`390`	`390`	`return selectedIde`
`391`	`391`	`}`
`392`		`- return null`
	`392`	`+ return "$productCode-$buildNumber"`
`393`	`393`	`}`
`394`	`394`
`395`	`395`	`private fun installJBClient(selectedIde: String, environmentId: String): Job = context.cs.launch {`