fixup! fixup! Add gendocs ci step

cmoog · cmoog · commit a890a5264984 · 2020-08-13T09:20:46.000-05:00
diff --git a/ci/steps/fmt.sh b/ci/steps/fmt.sh
@@ -1,16 +1,17 @@
 #!/bin/bash
+
+set -euo pipefail
+
 echo "Formatting..."
 
 go mod tidy
 gofmt -w -s .
 goimports -w "-local=$$(go list -m)" .
 
-if [ "$CI" != "" ]; then
-  if [[ $(git ls-files --other --modified --exclude-standard) != "" ]]; then
+if [[ ${CI-} && $(git ls-files --other --modified --exclude-standard) ]]; then
     echo "Files need generation or are formatted incorrectly:"
     git -c color.ui=always status | grep --color=no '\e\[31m'
     echo "Please run the following locally:"
     echo "  ./ci/steps/fmt.sh"
     exit 1
   fi
-fi
diff --git a/ci/steps/gendocs.sh b/ci/steps/gendocs.sh
@@ -1,4 +1,7 @@
 #!/bin/bash
+
+set -euo pipefail
+
 echo "Generating docs..."
 
 cd "$(dirname "$0")"
@@ -13,12 +16,10 @@ for filename in ./docs/*.md; do
 done
 
 
-if [ "$CI" != "" ]; then
-  if [[ $(git ls-files --other --modified --exclude-standard) != "" ]]; then
-    echo "Documentation needs generation:"
-    git -c color.ui=always status | grep --color=no '\e\[31m'
-    echo "Please run the following locally:"
-    echo "  ./ci/steps/gendocs.sh"
-    exit 1
-  fi
-fi
+if [[ ${CI-} && $(git ls-files --other --modified --exclude-standard) ]]; then
+  echo "Documentation needs generation:"
+  git -c color.ui=always status | grep --color=no '\e\[31m'
+  echo "Please run the following locally:"
+  echo "  ./ci/steps/gendocs.sh"
+  exit 1
+fi
diff --git a/ci/steps/lint.sh b/ci/steps/lint.sh
@@ -1,6 +1,8 @@
 #!/bin/bash
 
+set -euo pipefail
+
 echo "Linting..."
 
 go vet ./...
-golint -set_exit_status ./...
+golint -set_exit_status ./...
