Add confirmation prompt to 'coder envs edit' (#305)

lilshoff · web-flow · commit c4d9c0e960d8 · 2021-03-30T11:26:26.000-07:00
diff --git a/docs/coder_envs_edit.md b/docs/coder_envs_edit.md
@@ -24,6 +24,7 @@ coder envs edit back-end-env --disk 20
   -c, --cpu float32      The number of cpu cores the environment should be provisioned with.
   -d, --disk int         The amount of disk storage an environment should be provisioned with.
       --follow           follow buildlog after initiating rebuild
+      --force            force rebuild without showing a confirmation prompt
   -g, --gpu int          The amount of disk storage to provision the environment with.
   -h, --help             help for edit
   -i, --image string     name of the image you want the environment to be based off of.
diff --git a/internal/cmd/envs.go b/internal/cmd/envs.go
@@ -430,6 +430,7 @@ func editEnvCmd() *cobra.Command {
 		gpus   int
 		follow bool
 		user   string
+		force  bool
 	)
 
 	cmd := &cobra.Command{
@@ -482,6 +483,19 @@ coder envs edit back-end-env --disk 20`,
 				return err
 			}
 
+			if !force && env.LatestStat.ContainerStatus == coder.EnvironmentOn {
+				_, err = (&promptui.Prompt{
+					Label:     fmt.Sprintf("Rebuild environment %q? (will destroy any work outside of your home directory)", env.Name),
+					IsConfirm: true,
+				}).Run()
+				if err != nil {
+					return clog.Fatal(
+						"failed to confirm prompt", clog.BlankLine,
+						clog.Tipf(`use "--force" to rebuild without a confirmation prompt`),
+					)
+				}
+			}
+
 			if err := client.EditEnvironment(ctx, env.ID, *req); err != nil {
 				return xerrors.Errorf("failed to apply changes to environment %q: %w", envName, err)
 			}
@@ -510,6 +524,7 @@ coder envs edit back-end-env --disk 20`,
 	cmd.Flags().IntVarP(&gpus, "gpu", "g", 0, "The amount of disk storage to provision the environment with.")
 	cmd.Flags().BoolVar(&follow, "follow", false, "follow buildlog after initiating rebuild")
 	cmd.Flags().StringVar(&user, "user", coder.Me, "Specify the user whose resources to target")
+	cmd.Flags().BoolVar(&force, "force", false, "force rebuild without showing a confirmation prompt")
 	return cmd
 }
 
diff --git a/internal/cmd/envs_test.go b/internal/cmd/envs_test.go
@@ -108,7 +108,7 @@ func Test_env_create(t *testing.T) {
 
 	// edit the CPU of the environment
 	cpu = 2.1
-	res = execute(t, nil, "envs", "edit", name, fmt.Sprintf("--cpu=%f", cpu), "--follow")
+	res = execute(t, nil, "envs", "edit", name, fmt.Sprintf("--cpu=%f", cpu), "--follow", "--force")
 	res.success(t)
 
 	// assert that the CPU actually did change after edit
diff --git a/internal/cmd/rebuild.go b/internal/cmd/rebuild.go
@@ -43,7 +43,7 @@ coder envs rebuild backend-env --force`,
 
 			if !force && env.LatestStat.ContainerStatus == coder.EnvironmentOn {
 				_, err = (&promptui.Prompt{
-					Label:     fmt.Sprintf("Rebuild environment \"%s\"? (will destroy any work outside of /home)", env.Name),
+					Label:     fmt.Sprintf("Rebuild environment %q? (will destroy any work outside of your home directory)", env.Name),
 					IsConfirm: true,
 				}).Run()
 				if err != nil {
