Thanks to visit codestin.com
Credit goes to github.com

Skip to content

flake: TestServer/Prometheus/DBMetricsEnabled #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dannykopping opened this issue Jan 20, 2025 · 2 comments · Fixed by coder/coder#17297
Closed

flake: TestServer/Prometheus/DBMetricsEnabled #282

dannykopping opened this issue Jan 20, 2025 · 2 comments · Fixed by coder/coder#17297
Assignees
@johnstcn
Labels
flake

Comments

@dannykopping
Copy link
Collaborator

Seen here: https://github.com/coder/coder/actions/runs/12862523784/job/35857591349?pr=16169

    server_test.go:1026: 
        	Error Trace:	/Users/runner/work/coder/coder/cli/server_test.go:1026
        	Error:      	Condition never satisfied
        	Test:       	TestServer/Prometheus/DBMetricsEnabled
        	Messages:   	didn't find coderd_db_query_latencies_seconds in time

Not sure if related to previous flake coder/coder#13453
@johnstcn
Copy link
Member

johnstcn commented Apr 8, 2025

Seen here: https://github.com/coder/coder/actions/runs/14334610404/job/40178436381?pr=17291#step:8:669

@johnstcn johnstcn assigned johnstcn and unassigned coadler Apr 8, 2025
@johnstcn johnstcn mentioned this issue Apr 8, 2025
Merged
@johnstcn
Copy link
Member

johnstcn commented Apr 8, 2025 •
edited
Loading

As far as I can tell, the prometheus server just isn't starting up sometimes within the allotted time (from the perspective of the test). It may be due to the port we picked having been reallocated, sadly :(

johnstcn added a commit to coder/coder that referenced this issue Apr 8, 2025
@johnstcn
chore(cli): refactor TestServer/Prometheus to use testutil.Eventually (…
389e88e 
…#17295)

Updates coder/internal#282

Refactors existing tests to use `testutil.Eventually` which plays nicer
with `testutil.Context`.
@johnstcn johnstcn mentioned this issue Apr 8, 2025
Merged
johnstcn added a commit to coder/coder that referenced this issue Apr 10, 2025
@johnstcn
chore(cli): avoid use of testutil.RandomPort() in prometheus test (#1…
c756fff 
…7297)

Should hopefully fix coder/internal#282

Instead of picking a random port for the prometheus server, listen on
`:0` and read the port from the CLI stdout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cli): avoid use of testutil.RandomPort() in prometheus test coder/coder
3 participants
@dannykopping @johnstcn @coadler