fix: make attributes type more specific

Parkreiner · Parkreiner · commit 6a87fd18e55c · 2024-07-19T20:07:59.000Z
diff --git a/test.ts b/test.ts
@@ -90,7 +90,7 @@ type TerraformStateResource = {
   type: string;
   name: string;
   provider: string;
-  instances: [{ attributes: Record<string, any> }];
+  instances: [{ attributes: Record<string, JsonValue> }];
 };
 
 export interface TerraformState {
diff --git a/windows-rdp/main.test.ts b/windows-rdp/main.test.ts
@@ -23,7 +23,10 @@ function findWindowsRdpScript(state: TerraformState): string | null {
     }
 
     for (const instance of resource.instances) {
-      if (instance.attributes.display_name === "windows-rdp") {
+      if (
+        instance.attributes.display_name === "windows-rdp" &&
+        typeof instance.attributes.script === "string"
+      ) {
         return instance.attributes.script;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,10 @@ function findWindowsRdpScript(state: TerraformState): string \| null {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`for (const instance of resource.instances) {`
`26`		`- if (instance.attributes.display_name === "windows-rdp") {`
	`26`	`+ if (`
	`27`	`+ instance.attributes.display_name === "windows-rdp" &&`
	`28`	`+ typeof instance.attributes.script === "string"`
	`29`	`+ ) {`
`27`	`30`	`return instance.attributes.script;`
`28`	`31`	`}`
`29`	`32`	`}`