Update coder-login module to use coder_env resources

blink-so[bot] · matifali · blink-so[bot] · commit e3ce4b0212c8 · 2025-08-26T08:56:44.000Z
- Replaced coder_script resource with coder_env resources for CODER_SESSION_TOKEN and CODER_URL
- Removed run.sh script file in favor of native Terraform provider resources
- Added comprehensive Terraform tests with mocked data validation
- Uses correct environment variable names as per coder CLI documentation
- Cleaner approach using native Terraform provider resources

Co-authored-by: Atif Ali &lt;atif@coder.com&gt;
diff --git a/registry/coder/modules/coder-login/README.md b/registry/coder/modules/coder-login/README.md
@@ -14,7 +14,7 @@ Automatically logs the user into Coder when creating their workspace.
 module "coder-login" {
   count    = data.coder_workspace.me.start_count
   source   = "registry.coder.com/coder/coder-login/coder"
-  version  = "1.0.31"
+  version = "1.1.0"
   agent_id = coder_agent.example.id
 }
 ```
diff --git a/registry/coder/modules/coder-login/main.tf b/registry/coder/modules/coder-login/main.tf
@@ -17,15 +17,14 @@ variable "agent_id" {
 data "coder_workspace" "me" {}
 data "coder_workspace_owner" "me" {}
 
-resource "coder_script" "coder-login" {
+resource "coder_env" "coder_session_token" {
   agent_id = var.agent_id
-  script = templatefile("${path.module}/run.sh", {
-    CODER_USER_TOKEN : data.coder_workspace_owner.me.session_token,
-    CODER_DEPLOYMENT_URL : data.coder_workspace.me.access_url
-  })
-  display_name       = "Coder Login"
-  icon               = "/icon/coder.svg"
-  run_on_start       = true
-  start_blocks_login = true
+  name     = "CODER_SESSION_TOKEN"
+  value    = data.coder_workspace_owner.me.session_token
 }
 
+resource "coder_env" "coder_url" {
+  agent_id = var.agent_id
+  name     = "CODER_URL"
+  value    = data.coder_workspace.me.access_url
+}
diff --git a/registry/coder/modules/coder-login/main.tftest.hcl b/registry/coder/modules/coder-login/main.tftest.hcl
@@ -0,0 +1,65 @@
+# Test for coder-login module
+
+run "test_coder_login_module" {
+  command = plan
+
+  variables {
+    agent_id = "test-agent-id"
+  }
+
+  # Test that the coder_env resources are created with correct configuration
+  assert {
+    condition     = coder_env.coder_session_token.agent_id == "test-agent-id"
+    error_message = "CODER_SESSION_TOKEN agent ID should match the input variable"
+  }
+
+  assert {
+    condition     = coder_env.coder_session_token.name == "CODER_SESSION_TOKEN"
+    error_message = "Environment variable name should be 'CODER_SESSION_TOKEN'"
+  }
+
+  assert {
+    condition     = coder_env.coder_url.agent_id == "test-agent-id"
+    error_message = "CODER_URL agent ID should match the input variable"
+  }
+
+  assert {
+    condition     = coder_env.coder_url.name == "CODER_URL"
+    error_message = "Environment variable name should be 'CODER_URL'"
+  }
+}
+
+# Test with mock data sources
+run "test_with_mock_data" {
+  command = plan
+
+  variables {
+    agent_id = "mock-agent"
+  }
+
+  # Mock the data sources for testing
+  override_data {
+    target = data.coder_workspace.me
+    values = {
+      access_url = "https://coder.example.com"
+    }
+  }
+
+  override_data {
+    target = data.coder_workspace_owner.me
+    values = {
+      session_token = "mock-session-token"
+    }
+  }
+
+  # Verify environment variables get the mocked values
+  assert {
+    condition     = coder_env.coder_url.value == "https://coder.example.com"
+    error_message = "CODER_URL should match workspace access_url"
+  }
+
+  assert {
+    condition     = coder_env.coder_session_token.value == "mock-session-token"
+    error_message = "CODER_SESSION_TOKEN should match workspace owner session_token"
+  }
+}
diff --git a/registry/coder/modules/coder-login/run.sh b/registry/coder/modules/coder-login/run.sh

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ Automatically logs the user into Coder when creating their workspace.`
`14`	`14`	`module "coder-login" {`
`15`	`15`	`count = data.coder_workspace.me.start_count`
`16`	`16`	`source = "registry.coder.com/coder/coder-login/coder"`
`17`		`- version = "1.0.31"`
	`17`	`+ version = "1.1.0"`
`18`	`18`	`agent_id = coder_agent.example.id`
`19`	`19`	`}`
`20`	`20`	```