allow NaN previous values to prevent any regressions

Emyrk · Emyrk · commit f2a4d107a14e · 2025-05-08T09:30:19.000-05:00
diff --git a/provider/parameter.go b/provider/parameter.go
@@ -653,7 +653,13 @@ func (v *Validation) Valid(typ OptionType, value string, previous *string) error
 			if previous != nil { // Only check if previous value exists
 				previousNum, err := strconv.Atoi(*previous)
 				if err != nil {
-					return fmt.Errorf("previous value %q is not a number", *previous)
+					// Do not throw an error for the previous value not being a number. Throwing an
+					// error here would cause an unrepairable state for the user. This is
+					// unfortunate, but there is not much we can do at this point.
+					// TODO: Maybe we should enforce this, and have the calling coderd
+					//  do something to resolve it. Such as doing this check before calling
+					//  terraform apply.
+					break
 				}
 
 				if v.Monotonic == ValidationMonotonicIncreasing && !(num >= previousNum) {
diff --git a/provider/testdata/parameter_table.md b/provider/testdata/parameter_table.md
@@ -28,6 +28,8 @@
 | NumDefDecBad         | number        | 4        |           | 5       |                   | decreasing |    |        |          | lower           |
 | NumDefDecEq          | number        | 5        |           | 5       |                   | decreasing |    | 5      | true     |                 |
 | NumDefIncEq          | number        | 5        |           | 5       |                   | increasing |    | 5      | true     |                 |
+| NumDefIncNaN         | number        | a        |           | 5       |                   | increasing |    | 5      | true     |                 |
+| NumDefDecNaN         | number        | b        |           | 5       |                   | decreasing |    | 5      | true     |                 |
 |                      |               |          |           |         |                   |            |    |        |          |                 |
 | StrDef               | string        |          |           | hello   |                   |            |    | hello  | true     |                 |
 | StrMonotonicity      | string        |          |           | hello   |                   | increasing |    |        |          | monotonic       |
