review feedback

aslilac · aslilac · commit 0d27b318d829 · 2024-11-07T18:10:08.000Z
diff --git a/internal/codersdkvalidator/group_name.go b/internal/codersdkvalidator/group_name.go
@@ -0,0 +1,10 @@
+package codersdkvalidator
+
+import (
+	"github.com/coder/coder/v2/codersdk"
+	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
+)
+
+func GroupName() validator.String {
+	return validatorFromFunc(codersdk.GroupNameValid, "value must be a valid group name")
+}
diff --git a/internal/codersdkvalidator/validator_from_func.go b/internal/codersdkvalidator/validator_from_func.go
@@ -43,7 +43,7 @@ func (v functionValidator) Description(_ context.Context) string {
 	if v.err != nil {
 		return v.err.Error()
 	}
-	return "value must be a valid name"
+	return v.defaultMessage
 }
 
 func (v functionValidator) MarkdownDescription(ctx context.Context) string {
diff --git a/internal/provider/group_resource.go b/internal/provider/group_resource.go
@@ -77,7 +77,7 @@ func (r *GroupResource) Schema(ctx context.Context, req resource.SchemaRequest,
 				MarkdownDescription: "The unique name of the group.",
 				Required:            true,
 				Validators: []validator.String{
-					codersdkvalidator.Name(),
+					codersdkvalidator.GroupName(),
 				},
 			},
 			"display_name": schema.StringAttribute{

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func (v functionValidator) Description(_ context.Context) string {`
`43`	`43`	`if v.err != nil {`
`44`	`44`	`return v.err.Error()`
`45`	`45`	`}`
`46`		`- return "value must be a valid name"`
	`46`	`+ return v.defaultMessage`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`func (v functionValidator) MarkdownDescription(ctx context.Context) string {`