Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 913c3ed

Browse files
fix: use postgres for tests instead of dbmem (#87)
Our provider acceptance tests caught a very minor bug in `dbmem`, causing all CI to fail against the latest Coder image. Since nobody runs Coder using `dbmem`, It'd be better to test that the provider runs against the DB that people actually use. Running the acceptance tests on my dogfood workspace took ~140 seconds, up from ~80 using `dbmem` - but I think it's a fine tradeoff, and also means we don't need to modify our test suite to workaround the bug.
1 parent 21bd3ee commit 913c3ed

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

integration/integration.go

-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ func StartCoder(ctx context.Context, t *testing.T, name string, useLicense bool)
5353
Env: []string{
5454
"CODER_HTTP_ADDRESS=0.0.0.0:3000", // Listen on all interfaces inside the container
5555
"CODER_ACCESS_URL=http://localhost:3000", // Set explicitly to avoid creating try.coder.app URLs.
56-
"CODER_IN_MEMORY=true", // We don't necessarily care about real persistence here.
5756
"CODER_TELEMETRY_ENABLE=false", // Avoid creating noise.
5857
},
5958
Labels: map[string]string{},

0 commit comments

Comments
 (0)