Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Validate enterprise-only fields during plan #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ethanndickson opened this issue Aug 5, 2024 · 1 comment · Fixed by #62
Closed

Validate enterprise-only fields during plan #61

ethanndickson opened this issue Aug 5, 2024 · 1 comment · Fixed by #62
Assignees

Comments

@ethanndickson
Copy link
Member

ethanndickson commented Aug 5, 2024

Currently, if a user sets an enterprise-only attribute, such as allow_user_autostart to false on a coderd_template, on an AGPL deployment, the resource will be created as coderd does not return an error. However, when the provider goes to read the state of the resource, it will note a state mismatch (as the field is always true for AGPL deployments), and report a provider error. This is very much confusing for users. Ideally, we should return a validation error forbidding this during a plan.

@ethanndickson ethanndickson self-assigned this Aug 5, 2024
@matifali
Copy link
Member

matifali commented Aug 5, 2024

As a reference, you can check how JFrog artifactory provider handles this. They check for licenses during provider initialization and do not work without a valid license.

Important

They are using SDKv2 and not the terraform plugin framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants