Remove coder.openFromSidebar from command list

code-asher · code-asher · commit 1bfd21480ffc · 2024-09-24T13:51:06.000-08:00
When searching for "open workspace" in the palette, this can come up
instead of the correct one (`coder.open`, also titled "open workspace").

coder.openFromSidebare should only be used to open workspaces from the
sidebar, it never makes sense for a user to manually run it from the
command palette because even if you have a tree item selected, it will
not be passed when running from the command palette; the tree item only
exists if you click the inline button.

If there was a way to get the selected tree item, it would be ideal to
enable the command while there was one (this would also allow adding a
key binding), but since there is not, use `false` to always hide it.
diff --git a/package.json b/package.json
@@ -192,6 +192,12 @@
       }
     ],
     "menus": {
+      "commandPalette": [
+          {
+              "command": "coder.openFromSidebar",
+              "when": "false"
+          }
+      ],
       "view/title": [
         {
           "command": "coder.logout",

Original file line number	Diff line number	Diff line change
`@@ -192,6 +192,12 @@`
`192`	`192`	`}`
`193`	`193`	`],`
`194`	`194`	`"menus": {`
	`195`	`+ "commandPalette": [`
	`196`	`+ {`
	`197`	`+ "command": "coder.openFromSidebar",`
	`198`	`+ "when": "false"`
	`199`	`+ }`
	`200`	`+ ],`
`195`	`201`	`"view/title": [`
`196`	`202`	`{`
`197`	`203`	`"command": "coder.logout",`