Prevent immediately polling when connecting

code-asher · code-asher · commit 5609d21a8724 · 2024-10-14T13:14:39.000-08:00
Now, calling fetchAndRefresh() is a no-op if the view is not visible.
diff --git a/src/workspacesProvider.ts b/src/workspacesProvider.ts
@@ -36,6 +36,7 @@ export class WorkspaceProvider implements vscode.TreeDataProvider<vscode.TreeIte
   private agentWatchers: Record<WorkspaceAgent["id"], AgentWatcher> = {}
   private timeout: NodeJS.Timeout | undefined
   private fetching = false
+  private visible = false
 
   constructor(
     private readonly getWorkspacesQuery: WorkspaceQuery,
@@ -48,10 +49,10 @@ export class WorkspaceProvider implements vscode.TreeDataProvider<vscode.TreeIte
   // fetchAndRefresh fetches new workspaces, re-renders the entire tree, then
   // keeps refreshing (if a timer length was provided) as long as the user is
   // still logged in and no errors were encountered fetching workspaces.
-  // Calling this while already refreshing is a no-op and will return
-  // immediately.
+  // Calling this while already refreshing or not visible is a no-op and will
+  // return immediately.
   async fetchAndRefresh() {
-    if (this.fetching) {
+    if (this.fetching || !this.visible) {
       return
     }
     this.fetching = true
@@ -146,6 +147,7 @@ export class WorkspaceProvider implements vscode.TreeDataProvider<vscode.TreeIte
    * Either start or stop the refresh timer based on visibility.
    */
   setVisibility(visible: boolean) {
+    this.visible = visible
     if (!visible) {
       this.cancelPendingRefresh()
     } else {
