models: split auth with strings.SplitN

spinlock · spinlock · commit f8bc4e320e6d · 2017-09-18T09:30:50.000+08:00
diff --git a/pkg/models/etcd/etcdclient.go b/pkg/models/etcd/etcdclient.go
@@ -51,7 +51,7 @@ func New(addrlist string, auth string, timeout time.Duration) (*Client, error) {
 	}
 
 	if auth != "" {
-		split := strings.Split(auth, ":")
+		split := strings.SplitN(auth, ":", 2)
 		if len(split) != 2 || split[0] == "" {
 			return nil, errors.Errorf("invalid auth")
 		}
diff --git a/pkg/models/zk/zkclient.go b/pkg/models/zk/zkclient.go
@@ -60,7 +60,7 @@ func NewWithLogfunc(addrlist string, auth string, timeout time.Duration, logfunc
 		logger: &zkLogger{logfunc},
 	}
 	if auth != "" {
-		split := strings.Split(auth, ":")
+		split := strings.SplitN(auth, ":", 2)
 		if len(split) != 2 || split[0] == "" {
 			return nil, errors.Errorf("invalid auth")
 		}

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ func New(addrlist string, auth string, timeout time.Duration) (*Client, error) {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`if auth != "" {`
`54`		`- split := strings.Split(auth, ":")`
	`54`	`+ split := strings.SplitN(auth, ":", 2)`
`55`	`55`	`if len(split) != 2 \|\| split[0] == "" {`
`56`	`56`	`return nil, errors.Errorf("invalid auth")`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ func NewWithLogfunc(addrlist string, auth string, timeout time.Duration, logfunc`
`60`	`60`	`logger: &zkLogger{logfunc},`
`61`	`61`	`}`
`62`	`62`	`if auth != "" {`
`63`		`- split := strings.Split(auth, ":")`
	`63`	`+ split := strings.SplitN(auth, ":", 2)`
`64`	`64`	`if len(split) != 2 \|\| split[0] == "" {`
`65`	`65`	`return nil, errors.Errorf("invalid auth")`
`66`	`66`	`}`