fix(cli/ssh): Fetch up-to-date build info to avoid ws has no agents (coder#7650)

mafredri · web-flow · commit b6c8e5be4860 · 2023-05-24T12:37:22.000+03:00
Fixes coder#5836
diff --git a/cli/ssh.go b/cli/ssh.go
@@ -349,7 +349,7 @@ func getWorkspaceAndAgent(ctx context.Context, inv *clibase.Invocation, client *
 		err            error
 	)
 
-	workspace, err = namedWorkspace(inv.Context(), client, workspaceParts[0])
+	workspace, err = namedWorkspace(ctx, client, workspaceParts[0])
 	if err != nil {
 		return codersdk.Workspace{}, codersdk.WorkspaceAgent{}, err
 	}
@@ -362,6 +362,11 @@ func getWorkspaceAndAgent(ctx context.Context, inv *clibase.Invocation, client *
 		if err != nil {
 			return codersdk.Workspace{}, codersdk.WorkspaceAgent{}, err
 		}
+		// Fetch up-to-date build information after completion.
+		workspace.LatestBuild, err = client.WorkspaceBuild(ctx, workspace.LatestBuild.ID)
+		if err != nil {
+			return codersdk.Workspace{}, codersdk.WorkspaceAgent{}, err
+		}
 	}
 	if workspace.LatestBuild.Transition == codersdk.WorkspaceTransitionDelete {
 		return codersdk.Workspace{}, codersdk.WorkspaceAgent{}, xerrors.Errorf("workspace %q is being deleted", workspace.Name)

Original file line number	Diff line number	Diff line change
`@@ -349,7 +349,7 @@ func getWorkspaceAndAgent(ctx context.Context, inv clibase.Invocation, client `
`349`	`349`	`err error`
`350`	`350`	`)`
`351`	`351`
`352`		`- workspace, err = namedWorkspace(inv.Context(), client, workspaceParts[0])`
	`352`	`+ workspace, err = namedWorkspace(ctx, client, workspaceParts[0])`
`353`	`353`	`if err != nil {`
`354`	`354`	`return codersdk.Workspace{}, codersdk.WorkspaceAgent{}, err`
`355`	`355`	`}`
`@@ -362,6 +362,11 @@ func getWorkspaceAndAgent(ctx context.Context, inv clibase.Invocation, client `
`362`	`362`	`if err != nil {`
`363`	`363`	`return codersdk.Workspace{}, codersdk.WorkspaceAgent{}, err`
`364`	`364`	`}`
	`365`	`+ // Fetch up-to-date build information after completion.`
	`366`	`+ workspace.LatestBuild, err = client.WorkspaceBuild(ctx, workspace.LatestBuild.ID)`
	`367`	`+ if err != nil {`
	`368`	`+ return codersdk.Workspace{}, codersdk.WorkspaceAgent{}, err`
	`369`	`+ }`
`365`	`370`	`}`
`366`	`371`	`if workspace.LatestBuild.Transition == codersdk.WorkspaceTransitionDelete {`
`367`	`372`	`return codersdk.Workspace{}, codersdk.WorkspaceAgent{}, xerrors.Errorf("workspace %q is being deleted", workspace.Name)`