Fix: setImage(Uri uri) should not be async, because sync is the expected behavior

Patrick Boos · Patrick Boos · commit 9250c5809957 · 2012-10-22T15:00:52.000+09:00
diff --git a/library/src/jp/cyberagent/android/gpuimage/GPUImage.java b/library/src/jp/cyberagent/android/gpuimage/GPUImage.java
@@ -126,7 +126,7 @@ public void setImage(final Uri uri) {
     }
 
     public void setImage(final File file) {
-        new SetImageTask(this, file).execute();
+        new LoadImageTask(this, file).run();
     }
 
     private String getPath(final Uri uri) {
@@ -273,15 +273,15 @@ public interface OnPictureSavedListener {
         void onPictureSaved(Uri uri);
     }
 
-    private class SetImageTask extends AsyncTask<Void, Void, Bitmap> {
+    private class LoadImageTask implements Runnable {
 
         private final GPUImage mGPUImage;
         private final File mImageFile;
         private final int mMaxWidth;
         private final int mMaxHeight;
 
         @SuppressWarnings("deprecation")
-        public SetImageTask(final GPUImage gpuImage, final File file) {
+        public LoadImageTask(final GPUImage gpuImage, final File file) {
             mImageFile = file;
             mGPUImage = gpuImage;
 
@@ -293,14 +293,9 @@ public SetImageTask(final GPUImage gpuImage, final File file) {
         }
 
         @Override
-        protected Bitmap doInBackground(final Void... params) {
-            return loadResizedImage(mImageFile);
-        }
-
-        @Override
-        protected void onPostExecute(final Bitmap result) {
-            super.onPostExecute(result);
-            mGPUImage.setImage(result);
+        public void run() {
+            Bitmap bitmap = loadResizedImage(mImageFile);
+            mGPUImage.setImage(bitmap);
         }
 
         private Bitmap loadResizedImage(final File imageFile) {
