Updated TargetState naming

coder137 · coder137 · commit a897d2c7c626 · 2022-02-21T15:50:02.000-08:00
diff --git a/buildcc/lib/target/include/target/common/target_state.h b/buildcc/lib/target/include/target/common/target_state.h
@@ -23,8 +23,8 @@ namespace buildcc {
 
 struct TargetState {
   void BuildCompleted();
-  void SetSourceState(FileExt file_extension);
-  void SetPch();
+  void SourceDetected(FileExt file_extension);
+  void PchDetected();
 
   bool IsBuilt() const { return build_; }
   bool ContainsPch() const { return contains_pch_; }
diff --git a/buildcc/lib/target/src/common/target_state.cpp b/buildcc/lib/target/src/common/target_state.cpp
@@ -22,7 +22,7 @@ namespace buildcc {
 
 void TargetState::BuildCompleted() { build_ = true; }
 
-void TargetState::SetSourceState(FileExt file_extension) {
+void TargetState::SourceDetected(FileExt file_extension) {
   switch (file_extension) {
   case FileExt::Asm:
     contains_asm_ = true;
@@ -40,6 +40,6 @@ void TargetState::SetSourceState(FileExt file_extension) {
   }
 }
 
-void TargetState::SetPch() { contains_pch_ = true; }
+void TargetState::PchDetected() { contains_pch_ = true; }
 
 } // namespace buildcc
diff --git a/buildcc/lib/target/src/target/build.cpp b/buildcc/lib/target/src/target/build.cpp
@@ -59,14 +59,14 @@ void Target::Build() {
 
   // PCH state
   if (!user_.pchs.empty()) {
-    state_.SetPch();
+    state_.PchDetected();
   }
 
   // Source - Object relation
   // Source state
   for (const auto &abs_source : user_.sources) {
     // Set state
-    state_.SetSourceState(toolchain_.GetConfig().GetFileExt(abs_source));
+    state_.SourceDetected(toolchain_.GetConfig().GetFileExt(abs_source));
 
     // Relate input source with output object
     compile_object_.AddObjectData(abs_source);
diff --git a/buildcc/lib/target/test/target/test_target_state.cpp b/buildcc/lib/target/test/target/test_target_state.cpp
@@ -17,20 +17,20 @@ TEST(TargetStateTestGroup, SetSourceState) {
   buildcc::TargetState target_state;
 
   CHECK_FALSE(target_state.ContainsC());
-  target_state.SetSourceState(buildcc::FileExt::C);
+  target_state.SourceDetected(buildcc::FileExt::C);
   CHECK_TRUE(target_state.ContainsC());
 
   CHECK_FALSE(target_state.ContainsCpp());
-  target_state.SetSourceState(buildcc::FileExt::Cpp);
+  target_state.SourceDetected(buildcc::FileExt::Cpp);
   CHECK_TRUE(target_state.ContainsCpp());
 
   CHECK_FALSE(target_state.ContainsAsm());
-  target_state.SetSourceState(buildcc::FileExt::Asm);
+  target_state.SourceDetected(buildcc::FileExt::Asm);
   CHECK_TRUE(target_state.ContainsAsm());
 
   // Ignored
-  target_state.SetSourceState(buildcc::FileExt::Header);
-  target_state.SetSourceState(buildcc::FileExt::Invalid);
+  target_state.SourceDetected(buildcc::FileExt::Header);
+  target_state.SourceDetected(buildcc::FileExt::Invalid);
 }
 
 int main(int ac, char **av) {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ namespace buildcc {`
`22`	`22`
`23`	`23`	`void TargetState::BuildCompleted() { build_ = true; }`
`24`	`24`
`25`		`-void TargetState::SetSourceState(FileExt file_extension) {`
	`25`	`+void TargetState::SourceDetected(FileExt file_extension) {`
`26`	`26`	`switch (file_extension) {`
`27`	`27`	`case FileExt::Asm:`
`28`	`28`	`contains_asm_ = true;`
`@@ -40,6 +40,6 @@ void TargetState::SetSourceState(FileExt file_extension) {`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
`43`		`-void TargetState::SetPch() { contains_pch_ = true; }`
	`43`	`+void TargetState::PchDetected() { contains_pch_ = true; }`
`44`	`44`
`45`	`45`	`} // namespace buildcc`