Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 8d5bc1a

Browse files
olofjtorvalds
authored andcommitted
ARM: dt: Only print warning, not WARN() on bad cpu map in device tree
Due to recent changes and expecations of proper cpu bindings, there are now cases for many of the in-tree devicetrees where a WARN() will hit on boot due to badly formatted /cpus nodes. Downgrade this to a pr_warn() to be less alarmist, since it's not a new problem. Tested on Arndale, Cubox, Seaboard and Panda ES. Panda hits the WARN without this, the others do not. Acked-by: Russell King <[email protected]> Signed-off-by: Olof Johansson <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 133841c commit 8d5bc1a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

arch/arm/kernel/devtree.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,10 @@ void __init arm_dt_init_cpu_maps(void)
152152
tmp_map[i] = hwid;
153153
}
154154

155-
if (WARN(!bootcpu_valid, "DT missing boot CPU MPIDR[23:0], "
156-
"fall back to default cpu_logical_map\n"))
155+
if (!bootcpu_valid) {
156+
pr_warn("DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map\n");
157157
return;
158+
}
158159

159160
/*
160161
* Since the boot CPU node contains proper data, and all nodes have

0 commit comments

Comments
 (0)