fix: remove null from useHtmlTableProps return signature (dead condition)

jsamr · jsamr · commit 52888c54d1d2 · 2021-10-12T10:50:41.000-03:00
diff --git a/packages/table-plugin/docs/table-plugin.md b/packages/table-plugin/docs/table-plugin.md
@@ -9,7 +9,7 @@
 |  Function | Description |
 |  --- | --- |
 |  [cssRulesFromSpecs(specs)](./table-plugin.cssrulesfromspecs.md) | Create css rules from a specification object. |
-|  [useHtmlTableProps({ key, style, tnode }, tableConfig)](./table-plugin.usehtmltableprops.md) | Extract props for the HTMLTable component from renderer function arguments. This function is especially usefull for custom table renderers. |
+|  [useHtmlTableProps({ style, tnode }, tableConfig)](./table-plugin.usehtmltableprops.md) | Extract props for the HTMLTable component from renderer function arguments. This function is especially usefull for custom table renderers. |
 
 ## Interfaces
 
diff --git a/packages/table-plugin/docs/table-plugin.usehtmltableprops.md b/packages/table-plugin/docs/table-plugin.usehtmltableprops.md
@@ -9,19 +9,17 @@ Extract props for the HTMLTable component from renderer function arguments. This
 <b>Signature:</b>
 
 ```typescript
-export default function useHtmlTableProps({ key, style, tnode }: CustomRendererProps<TBlock>, tableConfig?: TableConfig): (HTMLTableProps & {
-    key?: string | number;
-}) | null;
+export default function useHtmlTableProps({ style, tnode }: CustomRendererProps<TBlock>, tableConfig?: TableConfig): HTMLTableProps;
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  { key, style, tnode } | CustomRendererProps&lt;TBlock&gt; |  |
+|  { style, tnode } | CustomRendererProps&lt;TBlock&gt; |  |
 |  tableConfig | [TableConfig](./table-plugin.tableconfig.md) | Override config options. |
 
 <b>Returns:</b>
 
-([HTMLTableProps](./table-plugin.htmltableprops.md) &amp; { key?: string \| number; }) \| null
+[HTMLTableProps](./table-plugin.htmltableprops.md)
 
diff --git a/packages/table-plugin/etc/table-plugin.api.md b/packages/table-plugin/etc/table-plugin.api.md
@@ -110,9 +110,7 @@ export interface TableStyleSpecs {
 }
 
 // @public
-export function useHtmlTableProps({ key, style, tnode }: CustomRendererProps<TBlock>, tableConfig?: TableConfig): (HTMLTableProps & {
-    key?: string | number;
-}) | null;
+export function useHtmlTableProps({ style, tnode }: CustomRendererProps<TBlock>, tableConfig?: TableConfig): HTMLTableProps;
 
 
 // (No @packageDocumentation comment for this package)
diff --git a/packages/table-plugin/src/useHtmlTableProps.ts b/packages/table-plugin/src/useHtmlTableProps.ts
@@ -22,7 +22,7 @@ import type { TBlock } from '@native-html/transient-render-engine';
 export default function useHtmlTableProps(
   { style, tnode }: CustomRendererProps<TBlock>,
   tableConfig?: TableConfig
-): HTMLTableProps | null {
+): HTMLTableProps {
   const { WebView, defaultWebViewProps, computeEmbeddedMaxWidth } =
     useSharedProps();
   const contentWidth = useContentWidth();
@@ -56,20 +56,13 @@ export default function useHtmlTableProps(
       : null
   ];
 
-  if (__DEV__ && !WebView) {
-    console.warn(
-      "@native-html/table-plugin: You must pass a WebView component from react-native-webview as a prop to the HTML component. The table won't be rendered."
-    );
-  }
-  return WebView
-    ? {
-        ...resolvedConfig,
-        ...stats,
-        html,
-        sourceBaseUrl: documentBaseUrl,
-        style: composedStyles,
-        onLinkPress,
-        WebView
-      }
-    : null;
+  return {
+    ...resolvedConfig,
+    ...stats,
+    html,
+    sourceBaseUrl: documentBaseUrl,
+    style: composedStyles,
+    onLinkPress,
+    WebView
+  };
 }

Original file line number	Diff line number	Diff line change
`@@ -110,9 +110,7 @@ export interface TableStyleSpecs {`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`// @public`
`113`		`-export function useHtmlTableProps({ key, style, tnode }: CustomRendererProps<TBlock>, tableConfig?: TableConfig): (HTMLTableProps & {`
`114`		`- key?: string \| number;`
`115`		`-}) \| null;`
	`113`	`+export function useHtmlTableProps({ style, tnode }: CustomRendererProps<TBlock>, tableConfig?: TableConfig): HTMLTableProps;`
`116`	`114`
`117`	`115`
`118`	`116`	`// (No @packageDocumentation comment for this package)`