Code tidy up

stealthcopter · stealthcopter · commit 0bc528fca277 · 2018-06-15T16:22:29.000+01:00
diff --git a/library/src/main/java/com/stealthcopter/networktools/IPTools.java b/library/src/main/java/com/stealthcopter/networktools/IPTools.java
@@ -90,7 +90,7 @@ public static ArrayList<InetAddress> getLocalIPv4Addresses() {
 
     /**
      * Check if the provided ip address refers to the localhost
-     * <p>
+     *
      * https://stackoverflow.com/a/2406819/315998
      *
      * @param addr - address to check
@@ -113,7 +113,7 @@ public static boolean isIpAddressLocalhost(InetAddress addr) {
 
     /**
      * Check if the provided ip address refers to the localhost
-     * <p>
+     *
      * https://stackoverflow.com/a/2406819/315998
      *
      * @param addr - address to check
diff --git a/library/src/main/java/com/stealthcopter/networktools/Ping.java b/library/src/main/java/com/stealthcopter/networktools/Ping.java
@@ -33,7 +33,7 @@ public interface PingListener {
 
     /**
      * Set the address to ping
-     * <p>
+     *
      * Note that a lookup is not performed here so that we do not accidentally perform a network
      * request on the UI thread.
      *
@@ -128,7 +128,7 @@ public void cancel() {
 
     /**
      * Perform a synchronous ping and return a result, will ignore number of times.
-     * <p>
+     *
      * Note that this should be performed on a background thread as it will perform a network
      * request
      *
diff --git a/library/src/main/java/com/stealthcopter/networktools/PortScan.java b/library/src/main/java/com/stealthcopter/networktools/PortScan.java
@@ -70,7 +70,7 @@ public static PortScan onAddress(InetAddress ia) {
 
     /**
      * Sets the timeout for each port scanned
-     * <p>
+     *
      * If you raise the timeout you may want to consider increasing the thread count {@link #setNoThreads(int)} to compensate.
      * We can afford to have quite a high thread count as most of the time the thread is just sitting
      * idle and waiting for the socket to timeout.
diff --git a/library/src/main/java/com/stealthcopter/networktools/SubnetDevices.java b/library/src/main/java/com/stealthcopter/networktools/SubnetDevices.java
@@ -15,7 +15,7 @@
  * Created by mat on 03/11/17.
  */
 public class SubnetDevices {
-    private int noThreads = 255;
+    private int noThreads = 100;
 
     private ArrayList<String> addresses;
     private ArrayList<Device> devicesFound;
diff --git a/library/src/main/java/com/stealthcopter/networktools/WakeOnLan.java b/library/src/main/java/com/stealthcopter/networktools/WakeOnLan.java
@@ -7,9 +7,9 @@
 
 /**
  * Created by mat on 09/12/15.
- * <p>
+ *
  * Tested this and it wakes my computer up :)
- * <p>
+ *
  * Ref: http://www.jibble.org/wake-on-lan/
  */
 public class WakeOnLan {
diff --git a/library/src/main/java/com/stealthcopter/networktools/ping/PingNative.java b/library/src/main/java/com/stealthcopter/networktools/ping/PingNative.java
@@ -63,29 +63,29 @@ public static PingResult ping(InetAddress host, int timeOutMillis) throws IOExce
 
     /**
      * getPingStats interprets the text result of a Linux activity_ping command
-     * <p>
+     *
      * Set pingError on error and return null
-     * <p>
+     *
      * http://en.wikipedia.org/wiki/Ping
-     * <p>
+     *
      * PING 127.0.0.1 (127.0.0.1) 56(84) bytes of data.
      * 64 bytes from 127.0.0.1: icmp_seq=1 ttl=64 time=0.251 ms
      * 64 bytes from 127.0.0.1: icmp_seq=2 ttl=64 time=0.294 ms
      * 64 bytes from 127.0.0.1: icmp_seq=3 ttl=64 time=0.295 ms
      * 64 bytes from 127.0.0.1: icmp_seq=4 ttl=64 time=0.300 ms
-     * <p>
+     *
      * --- 127.0.0.1 activity_ping statistics ---
      * 4 packets transmitted, 4 received, 0% packet loss, time 0ms
      * rtt min/avg/max/mdev = 0.251/0.285/0.300/0.019 ms
-     * <p>
+     *
      * PING 192.168.0.2 (192.168.0.2) 56(84) bytes of data.
-     * <p>
+     *
      * --- 192.168.0.2 activity_ping statistics ---
      * 1 packets transmitted, 0 received, 100% packet loss, time 0ms
-     * <p>
+     *
      * # activity_ping 321321.
      * activity_ping: unknown host 321321.
-     * <p>
+     *
      * 1. Check if output contains 0% packet loss : Branch to success -> Get stats
      * 2. Check if output contains 100% packet loss : Branch to fail -> No stats
      * 3. Check if output contains 25% packet loss : Branch to partial success -> Get stats
diff --git a/library/src/test/java/com/stealthcopter/networktools/MACToolsTest.java b/library/src/test/java/com/stealthcopter/networktools/MACToolsTest.java
@@ -39,12 +39,12 @@ public void testInvalidMACAddresses() {
     public void testMACGetBytes() {
         byte[] bytes = MACTools.getMacBytes("01:02:03:04:05:06");
 
-        assertEquals(bytes[0], 0x01);
-        assertEquals(bytes[1], 0x02);
-        assertEquals(bytes[2], 0x03);
-        assertEquals(bytes[3], 0x04);
-        assertEquals(bytes[4], 0x05);
-        assertEquals(bytes[5], 0x06);
+        assertEquals(0x01, bytes[0]);
+        assertEquals(0x02, bytes[1]);
+        assertEquals(0x03, bytes[2]);
+        assertEquals(0x04, bytes[3]);
+        assertEquals(0x05, bytes[4]);
+        assertEquals(0x06, bytes[5]);
     }
 
 
