fix(gatsby): add ./ prefix to paths in async-requires (gatsbyjs#20169)

wardpeet · GatsbyJS Bot · commit 4f2154a96f69 · 2019-12-17T17:34:56.000+02:00
* fix(gatsby): add ./ prefix to paths in async-requires

* add test to e2e-tests
diff --git a/e2e-tests/production-runtime/cypress/integration/1-production.js b/e2e-tests/production-runtime/cypress/integration/1-production.js
@@ -98,6 +98,13 @@ describe(`Production build tests`, () => {
     cy.getTestElement(`process.env.NOT_EXISTING_VAR`).should(`be.empty`)
   })
 
+  it(`should be able to create a page from component located in .cache directory`, () => {
+    cy.visit(`/page-from-cache/`).waitForRouteChange()
+
+    // `bar` is set in gatsby-node createPages
+    cy.getTestElement(`dom-marker`).contains(`[static-page-from-cache]`)
+  })
+
   describe(`Supports unicode characters in urls`, () => {
     it(`Can navigate directly`, () => {
       cy.visit(`/안녕/`, {
diff --git a/e2e-tests/production-runtime/gatsby-node.js b/e2e-tests/production-runtime/gatsby-node.js
@@ -1,4 +1,12 @@
 const path = require(`path`)
+const fs = require(`fs-extra`)
+
+exports.onPreBootstrap = () => {
+  fs.copyFileSync(
+    `./src/templates/static-page-from-cache.js`,
+    `./.cache/static-page-from-cache.js`
+  )
+}
 
 exports.createPages = ({ actions: { createPage } }) => {
   createPage({
@@ -83,6 +91,11 @@ exports.createPages = ({ actions: { createPage } }) => {
       domMarker: `dynamic-and-wildcard`,
     },
   })
+
+  createPage({
+    path: `/page-from-cache/`,
+    component: path.resolve(`./.cache/static-page-from-cache.js`),
+  })
 }
 
 exports.onCreatePage = ({ page, actions }) => {
diff --git a/e2e-tests/production-runtime/src/templates/static-page-from-cache.js b/e2e-tests/production-runtime/src/templates/static-page-from-cache.js
@@ -0,0 +1,7 @@
+import React from 'react'
+
+const StaticPage = () => (
+  <pre data-testid="dom-marker">[static-page-from-cache] static-sibling</pre>
+)
+
+export default StaticPage
diff --git a/packages/gatsby/src/bootstrap/requires-writer.js b/packages/gatsby/src/bootstrap/requires-writer.js
@@ -173,7 +173,7 @@ const preferDefault = m => m && m.default || m
       )
 
       return `  "${c.componentChunkName}": () => import("${slash(
-        relativeComponentPath
+        `./${relativeComponentPath}`
       )}" /* webpackChunkName: "${c.componentChunkName}" */)`
     })
     .join(`,\n`)}

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ const preferDefault = m => m && m.default \|\| m`
`173`	`173`	`)`
`174`	`174`
`175`	`175`	return ` "${c.componentChunkName}": () => import("${slash(
`176`		`- relativeComponentPath`
	`176`	+ `./${relativeComponentPath}`
`177`	`177`	)}" /* webpackChunkName: "${c.componentChunkName}" */)`
`178`	`178`	`})`
`179`	`179`	.join(`,\n`)}