Adding test for components rendered with Fabric with Paper's setNativeProps

elicwhite · elicwhite · commit a5e5f2a35056 · 2019-02-20T15:56:06.000-08:00
diff --git a/packages/react-native-renderer/src/ReactNativeSetNativeProps.js b/packages/react-native-renderer/src/ReactNativeSetNativeProps.js
@@ -19,7 +19,7 @@ import UIManager from 'UIManager';
 
 const ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner;
 
-export function setNativeProps(handle, nativeProps: Object) {
+export function setNativeProps(handle: any, nativeProps: Object) {
   if (handle._nativeTag == null) {
     warningWithoutStack(
       handle._nativeTag != null,
@@ -34,7 +34,6 @@ export function setNativeProps(handle, nativeProps: Object) {
   }
 
   const updatePayload = create(nativeProps, handle.viewConfig.validAttributes);
-
   // Avoid the overhead of bridge calls if there's no update.
   // This is an expensive no-op for Android, and causes an unnecessary
   // view invalidation for certain components (eg RCTTextInput) on iOS.
diff --git a/packages/react-native-renderer/src/__tests__/ReactFabricAndNative-test.internal.js b/packages/react-native-renderer/src/__tests__/ReactFabricAndNative-test.internal.js
@@ -13,12 +13,14 @@
 let React;
 let ReactFabric;
 let ReactNative;
+let UIManager;
 let createReactNativeComponentClass;
 
 describe('ReactFabric', () => {
   beforeEach(() => {
     jest.resetModules();
     ReactNative = require('react-native-renderer');
+    UIManager = require('UIManager');
     jest.resetModules();
     jest.mock('shared/ReactFeatureFlags', () =>
       require('shared/forks/ReactFeatureFlags.native-oss'),
@@ -49,4 +51,25 @@ describe('ReactFabric', () => {
     let handle = ReactNative.findNodeHandle(ref.current);
     expect(handle).toBe(2);
   });
+
+  it('sets native props with setNativeProps on Fabric nodes with the RN renderer', () => {
+    UIManager.updateView.mockReset();
+    const View = createReactNativeComponentClass('RCTView', () => ({
+      validAttributes: {title: true},
+      uiViewClassName: 'RCTView',
+    }));
+
+    let ref = React.createRef();
+
+    ReactFabric.render(<View title="bar" ref={ref} />, 11);
+    expect(UIManager.updateView).not.toBeCalled();
+    ReactNative.setNativeProps(ref.current, {title: 'baz'});
+    expect(UIManager.updateView).toHaveBeenCalledTimes(1);
+    expect(UIManager.updateView).toHaveBeenCalledWith(
+      expect.any(Number),
+      'RCTView',
+      {title: 'baz'},
+    );
+  });
+
 });
