Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit adf5a32

Browse files
authored
Revert "Fix email cursor jump (facebook#18379)"
This reverts commit 9b88b78.
1 parent 3f46844 commit adf5a32

File tree

7 files changed

+4
-203
lines changed

7 files changed

+4
-203
lines changed

fixtures/dom/src/components/Header.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ class Header extends React.Component {
7171
<option value="/text-inputs">Text Inputs</option>
7272
<option value="/number-inputs">Number Input</option>
7373
<option value="/password-inputs">Password Input</option>
74-
<option value="/email-inputs">Email Input</option>
7574
<option value="/selects">Selects</option>
7675
<option value="/textareas">Textareas</option>
7776
<option value="/input-change-events">

fixtures/dom/src/components/fixtures/email-inputs/EmailDisabledAttributesTestCase.js

Lines changed: 0 additions & 39 deletions
This file was deleted.

fixtures/dom/src/components/fixtures/email-inputs/EmailEnabledAttributesTestCase.js

Lines changed: 0 additions & 48 deletions
This file was deleted.

fixtures/dom/src/components/fixtures/email-inputs/JumpingCursorTestCase.js

Lines changed: 0 additions & 39 deletions
This file was deleted.

fixtures/dom/src/components/fixtures/email-inputs/index.js

Lines changed: 0 additions & 68 deletions
This file was deleted.

packages/react-dom/src/client/ReactDOMInput.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,8 +410,8 @@ export function setDefaultValue(
410410
value: *,
411411
) {
412412
if (
413-
// Focused number and email inputs synchronize on blur. See ChangeEventPlugin.js
414-
(type !== 'number' && type !== 'email') ||
413+
// Focused number inputs synchronize on blur. See ChangeEventPlugin.js
414+
type !== 'number' ||
415415
node.ownerDocument.activeElement !== node
416416
) {
417417
if (value == null) {

packages/react-dom/src/events/ChangeEventPlugin.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -236,17 +236,13 @@ function getTargetInstForInputOrChangeEvent(topLevelType, targetInst) {
236236
function handleControlledInputBlur(node) {
237237
const state = node._wrapperState;
238238

239-
if (
240-
!state ||
241-
!state.controlled ||
242-
(node.type !== 'number' && node.type !== 'email')
243-
) {
239+
if (!state || !state.controlled || node.type !== 'number') {
244240
return;
245241
}
246242

247243
if (!disableInputAttributeSyncing) {
248244
// If controlled, assign the value attribute to the current value on blur
249-
setDefaultValue(node, node.type, node.value);
245+
setDefaultValue(node, 'number', node.value);
250246
}
251247
}
252248

0 commit comments

Comments
 (0)