Register null component IDs at componentDidMount

iancmyers · iancmyers · commit c03a057f9aed · 2016-03-01T16:56:49.000-08:00
This pushes registering of null component IDs to componentDidMount.
The result that null component IDs are never registered during
server-side rendering, which fixes a memory leak with null component
IDs never being cleaned up server-side.
diff --git a/src/renderers/shared/reconciler/ReactEmptyComponent.js b/src/renderers/shared/reconciler/ReactEmptyComponent.js
@@ -25,6 +25,10 @@ var ReactEmptyComponentInjection = {
   },
 };
 
+function registerNullComponentID() {
+  ReactEmptyComponentRegistry.registerNullComponentID(this._rootNodeID);
+}
+
 var ReactEmptyComponent = function(instantiate) {
   this._currentElement = null;
   this._rootNodeID = null;
@@ -34,7 +38,7 @@ assign(ReactEmptyComponent.prototype, {
   construct: function(element) {
   },
   mountComponent: function(rootID, transaction, context) {
-    ReactEmptyComponentRegistry.registerNullComponentID(rootID);
+    transaction.getReactMountReady().enqueue(registerNullComponentID, this);
     this._rootNodeID = rootID;
     return ReactReconciler.mountComponent(
       this._renderedComponent,
