Include component stack in 'act(...)' warning (facebook#14855)

Sunil Pai · gaearon · commit c555c008b6e1 · 2019-02-14T17:20:49.000Z
* add a component stack trace to the act() warning

* pass tests

* nit
diff --git a/packages/react-dom/src/__tests__/ReactTestUtils-test.js b/packages/react-dom/src/__tests__/ReactTestUtils-test.js
@@ -634,10 +634,9 @@ describe('ReactTestUtils', () => {
       button.dispatchEvent(new MouseEvent('click', {bubbles: true}));
     });
     expect(button.innerHTML).toBe('2');
-    expect(() => setValueRef(1)).toWarnDev(
-      ['An update to App inside a test was not wrapped in act(...).'],
-      {withoutStack: 1},
-    );
+    expect(() => setValueRef(1)).toWarnDev([
+      'An update to App inside a test was not wrapped in act(...).',
+    ]);
     document.body.removeChild(container);
   });
 
diff --git a/packages/react-reconciler/src/ReactFiberScheduler.js b/packages/react-reconciler/src/ReactFiberScheduler.js
@@ -1839,8 +1839,10 @@ export function warnIfNotCurrentlyBatchingInDev(fiber: Fiber): void {
           '});\n' +
           '/* assert on the output */\n\n' +
           "This ensures that you're testing the behavior the user would see in the browser." +
-          ' Learn more at https://fb.me/react-wrap-tests-with-act',
+          ' Learn more at https://fb.me/react-wrap-tests-with-act' +
+          '%s',
         getComponentName(fiber.type),
+        getStackByFiberInDevAndProd(fiber),
       );
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1839,8 +1839,10 @@ export function warnIfNotCurrentlyBatchingInDev(fiber: Fiber): void {`
`1839`	`1839`	`'});\n' +`
`1840`	`1840`	`'/* assert on the output */\n\n' +`
`1841`	`1841`	`"This ensures that you're testing the behavior the user would see in the browser." +`
`1842`		`- ' Learn more at https://fb.me/react-wrap-tests-with-act',`
	`1842`	`+ ' Learn more at https://fb.me/react-wrap-tests-with-act' +`
	`1843`	`+ '%s',`
`1843`	`1844`	`getComponentName(fiber.type),`
	`1845`	`+ getStackByFiberInDevAndProd(fiber),`
`1844`	`1846`	`);`
`1845`	`1847`	`}`
`1846`	`1848`	`}`