Nicer messages

walaura · walaura · commit fb0a374117b0 · 2019-12-05T17:17:01.000Z
diff --git a/scripts/eslint-rules/__tests__/no-production-logging-test.internal.js b/scripts/eslint-rules/__tests__/no-production-logging-test.internal.js
@@ -43,31 +43,31 @@ ruleTester.run('no-production-logging', rule, {
       code: 'warningWithoutStack(test)',
       errors: [
         {
-          message: 'Wrap warningWithoutStack in a `if (__DEV__)` check',
+          message: `We don't emit warnings in production builds. Wrap warningWithoutStack() in an "if (__DEV__) {}" check`,
         },
       ],
     },
     {
       code: 'if (potato) { warningWithoutStack(test) }',
       errors: [
         {
-          message: 'Wrap warningWithoutStack in a `if (__DEV__)` check',
+          message: `We don't emit warnings in production builds. Wrap warningWithoutStack() in an "if (__DEV__) {}" check`,
         },
       ],
     },
     {
       code: 'warning(test)',
       errors: [
         {
-          message: 'Wrap warning in a `if (__DEV__)` check',
+          message: `We don't emit warnings in production builds. Wrap warning() in an "if (__DEV__) {}" check`,
         },
       ],
     },
     {
       code: 'if (__DEV__ || potato && true) { warning(test) }',
       errors: [
         {
-          message: 'Wrap warning in a `if (__DEV__)` check',
+          message: `We don't emit warnings in production builds. Wrap warning() in an "if (__DEV__) {}" check`,
         },
       ],
     },
diff --git a/scripts/eslint-rules/no-production-logging.js b/scripts/eslint-rules/no-production-logging.js
@@ -43,7 +43,7 @@ module.exports = function(context) {
   function report(node) {
     context.report({
       node: node,
-      message: 'Wrap {{identifier}} in a `if (__DEV__)` check',
+      message: `We don't emit warnings in production builds. Wrap {{identifier}}() in an "if (__DEV__) {}" check`,
       data: {
         identifier: node.callee.name,
       },

Original file line number	Diff line number	Diff line change
`@@ -43,31 +43,31 @@ ruleTester.run('no-production-logging', rule, {`
`43`	`43`	`code: 'warningWithoutStack(test)',`
`44`	`44`	`errors: [`
`45`	`45`	`{`
`46`		- message: 'Wrap warningWithoutStack in a `if (__DEV__)` check',
	`46`	+ message: `We don't emit warnings in production builds. Wrap warningWithoutStack() in an "if (__DEV__) {}" check`,
`47`	`47`	`},`
`48`	`48`	`],`
`49`	`49`	`},`
`50`	`50`	`{`
`51`	`51`	`code: 'if (potato) { warningWithoutStack(test) }',`
`52`	`52`	`errors: [`
`53`	`53`	`{`
`54`		- message: 'Wrap warningWithoutStack in a `if (__DEV__)` check',
	`54`	+ message: `We don't emit warnings in production builds. Wrap warningWithoutStack() in an "if (__DEV__) {}" check`,
`55`	`55`	`},`
`56`	`56`	`],`
`57`	`57`	`},`
`58`	`58`	`{`
`59`	`59`	`code: 'warning(test)',`
`60`	`60`	`errors: [`
`61`	`61`	`{`
`62`		- message: 'Wrap warning in a `if (__DEV__)` check',
	`62`	+ message: `We don't emit warnings in production builds. Wrap warning() in an "if (__DEV__) {}" check`,
`63`	`63`	`},`
`64`	`64`	`],`
`65`	`65`	`},`
`66`	`66`	`{`
`67`	`67`	`code: 'if (__DEV__ \|\| potato && true) { warning(test) }',`
`68`	`68`	`errors: [`
`69`	`69`	`{`
`70`		- message: 'Wrap warning in a `if (__DEV__)` check',
	`70`	+ message: `We don't emit warnings in production builds. Wrap warning() in an "if (__DEV__) {}" check`,
`71`	`71`	`},`
`72`	`72`	`],`
`73`	`73`	`},`