openbsd_pkg: revert "changed" simplification.

eest · eest · commit 8b2bd3e5a44c · 2014-09-28T10:01:34.000+02:00
module.exit_json() does not like when the "changed" variable contains a
match object:

TypeError: &lt;_sre.SRE_Match object at 0x81e2ae58&gt; is not JSON serializable
diff --git a/packaging/openbsd_pkg.py b/packaging/openbsd_pkg.py
@@ -336,9 +336,15 @@ def upgrade_packages(module):
 
     # Try to find any occurance of a package changing version like:
     # "bzip2-1.0.6->1.0.6p0: ok".
-    changed = re.search("\W\w.+->.+: ok\W", stdout)
-    if module.check_mode:
-        module.exit_json(changed=changed)
+    match = re.search("\W\w.+->.+: ok\W", stdout)
+    if match:
+        if module.check_mode:
+            module.exit_json(changed=True)
+
+        changed=True
+
+    else:
+        changed=False
 
     # It seems we can not trust the return value, so depend on the presence of
     # stderr to know if something failed.
