Slight cleanup for env code.

coderanger · coderanger · commit 6e0afef6ecca · 2014-01-27T23:11:05.000-08:00
diff --git a/providers/pip.rb b/providers/pip.rb
@@ -152,8 +152,8 @@ def remove_package(version)
 def pip_cmd(subcommand, version='')
   options = { :timeout => new_resource.timeout, :user => new_resource.user, :group => new_resource.group }
   environment = Hash.new
-  environment.merge!({ 'HOME' => ::File.expand_path("~#{new_resource.user}") }) if new_resource.user
-  environment.merge!(new_resource.environment) if new_resource.environment
+  environment['HOME'] = Dir.home(new_resource.user) if new_resource.user
+  environment.merge!(new_resource.environment) if new_resource.environment && !new_resource.environment.empty?
   options[:environment] = environment
   shell_out!("#{which_pip(new_resource)} #{subcommand} #{new_resource.options} #{new_resource.package_name}#{version}", options)
 end
