Stop Chef::Exceptions::ShellCommandFailed deprecation messages

schisamo · schisamo · commit 87223e2a75b2 · 2013-02-24T14:35:30.000-05:00
Checking for a non-zero exit code accomplishes the same thing as
rescuing *::ShellCommandFailed.
diff --git a/providers/pip.rb b/providers/pip.rb
@@ -114,10 +114,8 @@ def current_installed_version
       delimeter = /\s/
       version_check_cmd = "pip --version"
     end
-    p = shell_out!(version_check_cmd)
-    p.stdout.split(delimeter)[1].strip
-  rescue Chef::Exceptions::ShellCommandFailed
-  rescue Mixlib::ShellOut::ShellCommandFailed
+    result = shell_out(version_check_cmd)
+    (result.exitstatus == 0) ? result.stdout.split(delimeter)[1].strip : nil
   end
 end
 
