chore: wip

mydearxym · mydearxym · commit 9e0520603f1c · 2019-08-08T17:36:22.000+08:00
diff --git a/lib/groupher_server/cms/delegates/article_curd.ex b/lib/groupher_server/cms/delegates/article_curd.ex
@@ -130,6 +130,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
     end
   end
 
+  @spec ensure_author_exists(User.t()) :: {:ok, User.t()}
   def ensure_author_exists(%User{} = user) do
     # unique_constraint: avoid race conditions, make sure user_id unique
     # foreign_key_constraint: check foreign key: user_id exsit or not
diff --git a/lib/groupher_server/cms/delegates/community_sync.ex b/lib/groupher_server/cms/delegates/community_sync.ex
@@ -4,6 +4,7 @@ defmodule GroupherServer.CMS.Delegate.CommunitySync do
   """
   import Ecto.Query, warn: false
   import Helper.ErrorCode
+  import Helper.CommonTypes
   # import ShortMaps
 
   alias Helper.ORM
@@ -17,6 +18,7 @@ defmodule GroupherServer.CMS.Delegate.CommunitySync do
   @doc """
   get wiki
   """
+  @spec get_wiki(Community.t()) :: {:ok, CommunityWiki.t()}
   def get_wiki(%Community{raw: raw}) do
     with {:ok, community} <- ORM.find_by(Community, raw: raw),
          {:ok, wiki} <- ORM.find_by(CommunityWiki, community_id: community.id) do
@@ -30,6 +32,7 @@ defmodule GroupherServer.CMS.Delegate.CommunitySync do
   @doc """
   get cheatsheet
   """
+  @spec get_cheatsheet(Community.t()) :: {:ok, CommunityCheatsheet.t()}
   def get_cheatsheet(%Community{raw: raw}) do
     with {:ok, community} <- ORM.find_by(Community, raw: raw),
          {:ok, wiki} <- ORM.find_by(CommunityCheatsheet, community_id: community.id) do
@@ -43,6 +46,7 @@ defmodule GroupherServer.CMS.Delegate.CommunitySync do
   @doc """
   sync wiki
   """
+  @spec sync_github_content(Community.t(), atom) :: {:ok, CommunityWiki.t()}
   def sync_github_content(%Community{id: id}, :wiki, attrs) do
     with {:ok, community} <- ORM.find(Community, id) do
       attrs = Map.merge(attrs, %{community_id: community.id})
@@ -54,6 +58,7 @@ defmodule GroupherServer.CMS.Delegate.CommunitySync do
   @doc """
   sync cheatsheet
   """
+  @spec sync_github_content(Community.t(), atom()) :: {:ok, CommunityCheatsheet.t()}
   def sync_github_content(%Community{id: id}, :cheatsheet, attrs) do
     with {:ok, community} <- ORM.find(Community, id) do
       attrs = Map.merge(attrs, %{community_id: community.id})
@@ -65,10 +70,17 @@ defmodule GroupherServer.CMS.Delegate.CommunitySync do
   @doc """
   add contributor to exsit wiki contributors list
   """
+  @spec add_contributor(Community.t(), github_contributor()) ::
+          {:ok, CommunityWiki} | custom_error()
   def add_contributor(%CommunityWiki{id: id}, contributor_attrs) do
     do_add_contributor(CommunityWiki, id, contributor_attrs)
   end
 
+  @doc """
+  add contributor to exsit cheatsheet contributors list
+  """
+  @spec add_contributor(Community.t(), github_contributor()) ::
+          {:ok, CommunityCheatsheet} | custom_error()
   def add_contributor(%CommunityCheatsheet{id: id}, contributor_attrs) do
     do_add_contributor(CommunityCheatsheet, id, contributor_attrs)
   end
diff --git a/lib/helper/common_types.ex b/lib/helper/common_types.ex
@@ -0,0 +1,17 @@
+defmodule Helper.CommonTypes do
+  @moduledoc """
+  common types for lint
+  """
+
+  @type github_contributor :: %{
+          github_id: String.t(),
+          avatar: String.t(),
+          html_url: String.t(),
+          nickname: String.t(),
+          bio: nil | String.t(),
+          location: nil | String.t(),
+          company: nil | String.t()
+        }
+
+  @type custom_error :: {:error, [message: String.t(), code: Number.t()]}
+end
