Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

Commit 883ffc2

Browse files
author
M-ZubairAhmed
committed
Merge branch 'tests' of github.com:coderplex/coderplex into tests
2 parents 8f03ed6 + a3c887e commit 883ffc2

File tree

4 files changed

+11
-18
lines changed

4 files changed

+11
-18
lines changed

.github/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# *Required* Comment to reply with
44
requestInfoReplyComment: >
5-
Hey there, You did not give us whole lot of info for this issue. We would appreciate if you could provide us with more details :exclamation: :warning: :barber:
5+
We would appreciate it if you could provide us with more info about this issue/pr!
66
77
# *OPTIONAL* Label to be added to Issues and Pull Requests with insufficient information given
88
requestInfoLabelToAdd: needs-more-info
@@ -13,13 +13,13 @@ requestInfoLabelToAdd: needs-more-info
1313

1414
# Comment to be posted to on first time issues
1515
newIssueWelcomeComment: >
16-
Thanks for opening your first issue here!
16+
Thanks for opening this issue, a maintainer will get back to you shortly!
1717
1818
# Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome
1919

2020
# Comment to be posted to on PRs from first time contributors in your repository
2121
newPRWelcomeComment: >
22-
:smiley: Thanks for opening this pull request!, :busts_in_silhouette: maintainers will get back to you with the review :mag:
22+
Thanks so much for opening your first PR here!
2323
2424
# Configuration for first-pr-merge - https://github.com/behaviorbot/first-pr-merge
2525

CONTRIBUTING.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
We welcome pull requests from hackerspace members (our students) and seasoned JavaScript developers alike! Follow these steps to contribute:
44

5-
1. Find an issue that needs assistance by searching for the [Help Wanted](https://github.com/coderplex/coderplex/labels/help%20wanted) tag.
5+
1. Find an issue that needs assistance by searching for the [Help Wanted](https://github.com/coderplex/coderplex/labels/help-wanted) tag.
66

77
1. Let us know you are working on it by posting a comment on the issue.
88

@@ -14,20 +14,16 @@ Working on your first Pull Request? You can learn how from this *free* series [H
1414

1515
## Running this project locally
1616

17-
1. Make sure you have [NodeJS](https://nodejs.org/) and [npm](https://www.npmjs.com/) installed.
17+
1. Make sure you have [NodeJS](https://nodejs.org/) and [Yarn](https://yarnpkg.com/en/docs/install) installed.
1818
> Make sure you install node version 8 or above and check node version by running `node -v`
1919
1. Then clone this repo
2020
```bash
21-
git clone git@github.com:coderplex/coderplex.git
21+
git clone https://github.com/coderplex/coderplex.git
2222
```
2323
1. `cd coderplex`
2424
1. `npm install`
2525
1. `npm run dev` to start local development server
2626
1. App opens at `localhost:3000`
2727

28-
2928
**Note:**
30-
31-
So our team's official policy (for now) is:
32-
we only use Yarn as our official Node package manager, and so we request you to use Yarn instead of
33-
npm and commit yarn.lock file.
29+
> So our team's official policy (for now) is: We only use [Yarn](https://yarnpkg.com/en/docs/install) as our official Node package manager, and so we request you to use Yarn instead of npm and commit yarn.lock file.

components/footer.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import FaFacebook from 'react-icons/lib/fa/facebook';
33
import FaYoutube from 'react-icons/lib/fa/youtube-play';
44
import FaGithub from 'react-icons/lib/fa/github-alt';
55
import FaInstagram from 'react-icons/lib/fa/instagram';
6+
import FaTwitter from 'react-icons/lib/fa/twitter';
67

78
export default () => (
89
<footer>
@@ -31,7 +32,7 @@ export default () => (
3132
</a>
3233
</li>
3334
<li>
34-
<a href="https://www.meetup.com/coderplex/">m</a>
35+
<a href="https://www.twitter.com/coderplex/"><FaTwitter size={20}/></a>
3536
</li>
3637
</ul>
3738
</div>

pages/learn/index.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,10 @@ class Learn extends React.Component {
8282
key={subject.id}
8383
>
8484
<Link
85-
href={`/learn/subject?id=${subject.subjectId}`}
8685
as={subject.url}
86+
href={`/learn/subject?id=${subject.subjectId}`}
8787
>
88-
<Card
89-
as="a"
90-
raised
91-
label={{ as: 'a', corner: 'left', icon: 'heart' }}
92-
>
88+
<Card href={subject.url} raised>
9389
<Label attached="bottom right">
9490
<Popup
9591
trigger={

0 commit comments

Comments
 (0)