Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

Commit a78be21

Browse files
committed
setup markdownlinter
1 parent 77c24cf commit a78be21

File tree

5 files changed

+206
-113
lines changed

5 files changed

+206
-113
lines changed

.github/CONTRIBUTING.md

Lines changed: 117 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -1,81 +1,91 @@
1+
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
2+
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
3+
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
4+
5+
- [How to Contribute](#how-to-contribute)
6+
- [Code of Conduct](#code-of-conduct)
7+
- [Open Development](#open-development)
8+
- [Branching Model](#branching-model)
9+
- [Development Workflow](#development-workflow)
10+
- [Work on Issues](#work-on-issues)
11+
- [Proposing a Change](#proposing-a-change)
12+
- [Prerequisites](#prerequisites)
13+
- [Sending a Pull Request](#sending-a-pull-request)
14+
- [Running Locally](#running-locally)
15+
- [Before submitting](#before-submitting)
16+
- [After submitting](#after-submitting)
17+
- [Received a review request](#received-a-review-request)
18+
- [How to get in touch](#how-to-get-in-touch)
19+
- [Appendix](#appendix)
20+
- [1. Node Version Manager](#1-node-version-manager)
21+
- [nvm for Linux & macOS](#nvm-for-linux--macos)
22+
- [nvm-windows for Windows](#nvm-windows-for-windows)
23+
- [2. Local host occupied](#2-local-host-occupied)
24+
25+
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
26+
127
# How to Contribute
228

329
Coderplex web application comprises of two repositories :
430

5-
- [Coderplex](https://github.com/coderplex/coderplex) : Frontend of the application
6-
7-
- [Coderplex-Backend](https://github.com/coderplex/coderplex-backend) : Backend of the application
8-
9-
## Index
10-
1. [Code of Conduct](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#code-of-conduct)
11-
2. [Open Development](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#open-development)
12-
3. [Branching Model](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#branching-model)
13-
4. [Development Workflow](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#development-workflow)
14-
1. [Work on Issues](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#work-on-issues)
15-
2. [Proposing a Change](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#proposing-a-change)
16-
3. [Prerequisites](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#prerequisites)
17-
4. [Sending a Pull Request](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#sending-a-pull-request)
18-
1. [Running Locally](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#running-locally)
19-
2. [Before submitting](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#before-submitting)
20-
3. [After submitting](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#after-submitting)
21-
1. [Received a review request](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#received-a-review-request)
22-
5. [How to get in touch](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#how-to-get-in-touch)
23-
5. [Appendix](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#appendix)
24-
1. [Node Version Manager](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#1-node-version-manager)
25-
1. [Linux & macOS](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#nvm-for-linux--osx)
26-
2. [Windows](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#nvm-windows-for-windows)
27-
2. [Local host occupied](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#2-local-host-occupied)
31+
* [Coderplex](https://github.com/coderplex/coderplex) : Frontend of the application
2832

33+
* [Coderplex-Backend](https://github.com/coderplex/coderplex-backend) : Backend of the application
2934

3035
## Code of Conduct
36+
3137
Coderplex has adopted [Contributor Covenant](https://github.com/coderplex/coderplex/blob/develop/.github/CODE_OF_CONDUCT.md) that we expect project participants to adhere to.
3238

3339
## Open Development
40+
3441
All work related to the application takes place on Github itself. We use [Issues](https://github.com/coderplex/coderplex/issues) to track bugs, discuss ideas and to engage open source contributors. [Projects](https://github.com/coderplex/coderplex/projects) are used to keep track of everything and is our project management tool. We maintain [Wiki](https://github.com/coderplex/coderplex/wiki) for structuring our long term thoughts. Both core team members and contributors sends a pull request which goes through the same review process. Whole process is as transparent as it can be and we strive to keep it that way.
3542

3643
## Branching Model
37-
The `master` branch of coderplex is relatively stable branch which we update for every release. We also have auto deployment in place for that particular branch i.e any changes in that branch gets reflected in [https://coderplex.org](https://coderplex.org).
38-
It is highly recommended for both maintainers and contributors to raise a pull request to `develop` branch. Before every release we throughly test develop branch and merge into master.
44+
45+
The `master` branch of coderplex is relatively stable branch which we update for every release. We also have auto deployment in place for that particular branch i.e any changes in that branch gets reflected in [https://coderplex.org](https://coderplex.org). It is highly recommended for both maintainers and contributors to raise a pull request to `develop` branch. Before every release we throughly test develop branch and merge into master.
46+
3947
![Imgur](https://i.imgur.com/KPO2dLul.png)
40-
<br/>
41-
*A pull request to any other branch may most likely be closed by our bots.*
48+
49+
_A pull request to any other branch may most likely be closed by our bots_.
4250

4351
## Development Workflow
4452

4553
We welcome pull requests from beginners and seasoned javaScript developers alike!
4654

4755
### Work on Issues
48-
1. Find an issue that needs assistance by searching for the [open issues](https://github.com/coderplex/coderplex/labels/help-wanted).
49-
2. If you decide to fix an issue, please be sure to check the comment thread in case somebody is already working on a fix. If nobody is working on it at the moment, please leave a comment stating that you intend to work on it so other people don’t accidentally duplicate your effort.
50-
3. If somebody claims an issue but doesn’t follow up for more than a weeks, it’s fine to take over it but you should still leave a comment.
5156

57+
1. Find an issue that needs assistance by searching for the [open issues](https://github.com/coderplex/coderplex/labels/help-wanted).
58+
1. If you decide to fix an issue, please be sure to check the comment thread in case somebody is already working on a fix. If nobody is working on it at the moment, please leave a comment stating that you intend to work on it so other people don’t accidentally duplicate your effort.
59+
1. If somebody claims an issue but doesn’t follow up for more than a weeks, it’s fine to take over it but you should still leave a comment.
5260

5361
### Proposing a Change
62+
5463
1. Open a new issue if you would like report a bug or suggest improvements.
55-
2. Please wait for core team members to comment on the thread. This lets us reach an agreement on your proposal before you put significant effort into it.
64+
1. Please wait for core team members to comment on the thread. This lets us reach an agreement on your proposal before you put significant effort into it.
5665

5766
### Prerequisites
67+
5868
1. [NodeJS](https://nodejs.org/)
59-
<br/>
60-
Minimum version v8.0.0+
61-
```bash
62-
To check node version
63-
$ node -v
64-
```
65-
Any lower version than mentioned above may results in this [error](https://github.com/coderplex/coderplex/issues/100).
66-
> If you face problem updating your node then you might need a Node version manager tool. [Follow here]()
67-
68-
2. [Yarn](https://yarnpkg.com)
69-
<br/>
70-
Minimum version v1.2.0+
71-
<br/>
72-
Installing instructions are at [official docs](https://yarnpkg.com/en/docs/install#windows-tab).
73-
Use yarn over npm
74-
> Our team's official policy (for now) is: We only use [Yarn](https://yarnpkg.com/en/docs/install) as our official Node package manager, and so we request you to use Yarn instead of npm and commit `yarn.lock` file.
75-
76-
3. [Git](https://git-scm.com/download/linux)
77-
<br/>
78-
Familiarity with git is mandatory.
69+
70+
* Minimum version v8.0.0+
71+
72+
```bash
73+
To check node version
74+
node -v
75+
```
76+
77+
Any lower version than mentioned above may results in this [error](https://github.com/coderplex/coderplex/issues/100).
78+
79+
> If you face problem updating your node then you might need a Node version manager tool. [Follow here](#1-node-version-manager)
80+
81+
1. [Yarn](https://yarnpkg.com)
82+
83+
* Minimum version v1.2.0+
84+
* Installing instructions are at [official docs](https://yarnpkg.com/en/docs/install#windows-tab). Use yarn over npm
85+
86+
> Our team's official policy (for now) is: We only use [Yarn](https://yarnpkg.com/en/docs/install) as our official Node package manager, and so we request you to use Yarn instead of npm and commit `yarn.lock` file.
87+
88+
1. [Git](https://git-scm.com/download/linux) (Familiarity with git is mandatory).
7989

8090
### Sending a Pull Request
8191

@@ -85,88 +95,100 @@ We welcome pull requests from beginners and seasoned javaScript developers alike
8595

8696
1. Fork the [repository](https://github.com/coderplex/coderplex).
8797
1. Then clone your forked repository
88-
```bash
89-
$ git clone <your forked repository url>
90-
```
98+
```bash
99+
git clone <your forked repository url>
100+
```
91101
1. Move to the repository root folder
92-
```bash
93-
$ cd coderplex
94-
```
102+
```bash
103+
cd coderplex
104+
```
95105
1. Install dependencies
96-
```bash
97-
$ yarn
98-
```
106+
```bash
107+
yarn
108+
```
99109
1. Start the development server
100-
```bash
101-
$ yarn dev
102-
```
103-
App now opens at `localhost:3000` in your default browser.
104-
> You may get this [error]() if any other app is already running the above port.
110+
```bash
111+
yarn dev
112+
```
113+
App now opens at `localhost:3000` in your default browser.
114+
> You may get this [error](#2-local-host-occupied) if any other app is already running the above port.
115+
116+
#### Before submitting
105117

106-
#### Before submitting:
107118
1. From your fork, create a [branch](https://help.github.com/articles/creating-and-deleting-branches-within-your-repository/) and name it. eg. `typo-in-readme`
108119
1. If you’ve fixed a bug or added code that should be tested, add tests!
109120
1. Ensure that all test pass
110-
```bash
111-
$ yarn test
112-
```
121+
```bash
122+
yarn test
123+
```
113124
1. Run code formatters
114-
```bash
115-
$ yarn lint
116-
```
125+
```bash
126+
yarn lint
127+
```
117128
1. Add and commit your code. Please give meaning full commit messages.
118-
1. Pull latest code from [upstream repository's ](https://help.github.com/articles/merging-an-upstream-repository-into-your-fork/)`develop`, if in case anything new were merged while you were working on your fork.
129+
1. Pull latest code from [upstream repository's](https://help.github.com/articles/merging-an-upstream-repository-into-your-fork/)`develop`, if in case anything new were merged while you were working on your fork.
119130
1. Push the code to your fork.
120-
1. Raise the pull request from your created branch to `develop` branch of coderplex. [why develop instead of master branch?]()
131+
1. Raise the pull request from your created branch to `develop` branch of coderplex. [why develop instead of master branch?](https://www.atlassian.com/git/tutorials/comparing-workflows)
121132
1. Take some time to give a brief description of the work you have done.
122133

123134
#### After submitting
135+
124136
1. Wait for all checks to pass in below section.
125-
2. Your changes are deployed with a unique link `https://deploy-preview-xx--coderplex.netlify.com`. <br/>
126-
*`- xx` is your pull request number.*
127-
3. The core team will review your pull request and either merge it, request changes to it, or close it with an explanation.
137+
1. Your changes are deployed with a unique link `https://deploy-preview-xx--coderplex.netlify.com`.
138+
139+
_`- xx` is your pull request number._
140+
141+
1. The core team will review your pull request and either merge it, request changes to it, or close it with an explanation.
128142

129143
##### Received a review request
130-
- Work on the requested changes
131-
- Push the changes as you did earlier, the pull request will automatically catch those and update itself.
144+
145+
* Work on the requested changes
146+
* Push the changes as you did earlier, the pull request will automatically catch those and update itself.
132147

133148
### How to get in touch
134-
- Coderplex [Discord Channel](https://discord.gg/dVnQ2Gf)
135-
- Tweet core team members :
136-
- Vinay Puppal [@VinayPuppal](https://twitter.com/vinaypuppal)
137-
- Md-ZubairAhmed [@Md_ZubairAhmed](https://twitter.com/Md_ZubairAhmed)
149+
150+
* Coderplex [Discord Channel](https://discord.gg/dVnQ2Gf)
151+
* Tweet core team members :
152+
* Vinay Puppal [@VinayPuppal](https://twitter.com/vinaypuppal)
153+
* Md-ZubairAhmed [@Md_ZubairAhmed](https://twitter.com/Md_ZubairAhmed)
138154

139155
## Appendix
140-
##### 1. Node Version Manager
141156

142-
###### [nvm](https://github.com/creationix/nvm) for Linux & macOS
157+
### 1. Node Version Manager
158+
159+
#### [nvm](https://github.com/creationix/nvm) for Linux & macOS
160+
143161
```bash
144162
Installation
145-
$ curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.6/install.sh | bash
163+
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.6/install.sh | bash
146164

147165
Install latest node lts
148-
$ nvm install --lts
166+
nvm install --lts
149167

150168
Use installed version
151-
$ nvm use --lts
169+
nvm use --lts
152170

153171
Run the app in the same terminal session
154172
```
155-
*Make sure you have [curl](https://curl.haxx.se/) installed*
156173

157-
###### [nvm-windows](https://github.com/coreybutler/nvm-windows) for Windows
174+
_Make sure you have [curl](https://curl.haxx.se/) installed_
175+
176+
#### [nvm-windows](https://github.com/coreybutler/nvm-windows) for Windows
177+
158178
It comes with an [installer](https://github.com/coreybutler/nvm-windows#installation--upgrades).
159179

160180
```bash
161181
Install particular version
162-
$ nvm install 8.9.1
182+
nvm install 8.9.1
163183

164184
Use installed version
165-
$ nvm use 8.9.1
185+
nvm use 8.9.1
166186
```
167-
Still facing problem this [article](https://medium.com/appseed-io/how-to-run-multiple-versions-of-node-js-with-nvm-for-windows-ffbe5c7a2b47) from [@skounis ](https://twitter.com/skounis) explain in details.
168187

169-
##### 2. Local host occupied
188+
Still facing problem this [article](https://medium.com/appseed-io/how-to-run-multiple-versions-of-node-js-with-nvm-for-windows-ffbe5c7a2b47) from [@skounis](https://twitter.com/skounis) explain in details.
189+
190+
### 2. Local host occupied
191+
170192
```bash
171193
Error: listen EADDRINUSE :::3000
172194
at Object._errnoException (util.js:1024:11)
@@ -179,4 +201,5 @@ Error: listen EADDRINUSE :::3000
179201
at process._tickCallback (internal/process/next_tick.js:188:7)
180202
error Command failed with exit code 1.
181203
```
204+
182205
If you get this error while running `yarn dev` then probably another app is occupying `localhost:3000`. You may want to close that and run the command again.

.markdownlint.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"first-line-h1": false,
3+
"line-length": false,
4+
"ul-style": false
5+
}

README.md

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,21 @@
11
# Coderplex Website
22

3-
[![Greenkeeper badge](https://badges.greenkeeper.io/coderplex/coderplex.svg)](https://greenkeeper.io/)
4-
[![XO code style](https://img.shields.io/badge/code_style-XO-5ed9c7.svg)](https://github.com/sindresorhus/xo)
5-
[![styled with prettier](https://img.shields.io/badge/styled_with-prettier-ff69b4.svg)](https://github.com/prettier/prettier)
6-
[![Build Status](https://travis-ci.org/coderplex/coderplex.svg?branch=master)](https://travis-ci.org/coderplex/coderplex)
7-
[![License](https://img.shields.io/badge/License-BSD%203--Clause-blue.svg)](https://github.com/coderplex/coderplex/blob/master/LICENSE)
3+
[![Greenkeeper badge](https://badges.greenkeeper.io/coderplex/coderplex.svg)](https://greenkeeper.io/) [![XO code style](https://img.shields.io/badge/code_style-XO-5ed9c7.svg)](https://github.com/sindresorhus/xo) [![styled with prettier](https://img.shields.io/badge/styled_with-prettier-ff69b4.svg)](https://github.com/prettier/prettier) [![Build Status](https://travis-ci.org/coderplex/coderplex.svg?branch=master)](https://travis-ci.org/coderplex/coderplex) [![License](https://img.shields.io/badge/License-BSD%203--Clause-blue.svg)](https://github.com/coderplex/coderplex/blob/master/LICENSE)
84

9-
##### Join our community here at https://www.coderplex.org
10-
>:construction: under active development
5+
## Join our community here at [https://www.coderplex.org](https://www.coderplex.org)
6+
7+
> :construction: under active development
118
129
## About
1310

1411
This project mainly uses
1512

16-
* [ReactJS](https://reactjs.org/) - A declarative, efficient, and flexible JavaScript library for building user
17-
interfaces.
13+
* [ReactJS](https://reactjs.org/) - A declarative, efficient, and flexible JavaScript library for building user interfaces.
1814
* [Next.js](https://github.com/zeit/next.js/) - A minimalistic framework for server-rendered React applications.
1915
* [emotion](https://emotion.sh) - A high performance, lightweight css-in-js library.
2016

21-
2217
## Contributing
2318

24-
We welcome pull requests from beginners and seasoned javaScript developers alike!. You can work on open issues, fix bugs
25-
and more. Be sure to read our [contributing guide](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md) for
26-
hassel free contribution. <br/> This project follows ✨
27-
[All Contributors](https://github.com/kentcdodds/all-contributors) ✨ specifications to recognize all contributors.
19+
We welcome pull requests from beginners and seasoned javaScript developers alike!. You can work on open issues, fix bugs and more. Be sure to read our [contributing guide](https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md) for hassel free contribution.
20+
21+
This project follows ✨ [All Contributors](https://github.com/kentcdodds/all-contributors) ✨ specifications to recognize all contributors.

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"scripts": {
77
"test": "xo && jest",
88
"lint":
9-
"prettier 'utils/**/*.js' 'components/**/*.js' 'pages/**/*.js' 'lib/**/*.js' 'hocs/**/*.js' '*.js' --write && xo",
9+
"prettier 'utils/**/*.js' 'components/**/*.js' 'pages/**/*.js' 'lib/**/*.js' 'hocs/**/*.js' '*.js' --write && xo && markdownlint .",
1010
"precommit": "lint-staged",
1111
"analyze": "cross-env ANALYZE=1 next build",
1212
"dev": "cross-env NODE_ENV=development node server.js",
@@ -39,8 +39,8 @@
3939
"jest --findRelatedTests",
4040
"git add"
4141
],
42-
"*.md": ["prettier", "git add"],
43-
".github/CONTRIBUTING.md": ["doctoc", "git add"]
42+
"*.md": ["prettier", "markdownlint", "git add"],
43+
".github/CONTRIBUTING.md": ["doctoc", "prettier", "git add"]
4444
},
4545
"dependencies": {
4646
"babel-plugin-emotion": "^8.0.10",
@@ -80,6 +80,7 @@
8080
"husky": "^0.14.3",
8181
"jest": "^21.2.1",
8282
"lint-staged": "^5.0.0",
83+
"markdownlint-cli": "^0.5.0",
8384
"opn": "^5.1.0",
8485
"prettier": "^1.7.0",
8586
"raf": "^3.4.0",

0 commit comments

Comments
 (0)