Add Validation

elevenpassin · elevenpassin · commit ee15717f6059 · 2018-08-28T14:36:09.000+05:30
diff --git a/models/User.js b/models/User.js
@@ -15,10 +15,14 @@ const UserSchema = new Schema({
     required: true,
     minlength: 10
   },
-  mobile: Number,
+  mobile: {
+    type: Number,
+    default: 0
+  },
   bio: {
     type: String,
-    maxlength: 1000
+    maxlength: 1000,
+    default: ''
   },
   working: Boolean,
   forhire: Boolean,
@@ -36,7 +40,10 @@ const UserSchema = new Schema({
   techFamiliarWith: [String],
   techInterestedIn: [String],
   projects: [Schema.Types.ObjectId],
-  hits: Number
+  hits: {
+    type: Number,
+    default: 0
+  }
 })
 
 const User = mongoose.model('User', UserSchema)
diff --git a/models/UserProject.js b/models/UserProject.js
@@ -14,7 +14,10 @@ const UserProjectSchema = new Schema({
     minlength: 100,
     maxlength: 1000
   },
-  thumbnailUrl: String,
+  thumbnailUrl: {
+    type: String,
+    default: 'Some url to default thumbnail'
+  },
   creators: {
     type: [Schema.Types.ObjectId],
     required: true
@@ -23,7 +26,10 @@ const UserProjectSchema = new Schema({
     type: String,
     required: true
   },
-  hits: Number
+  hits: {
+    type: Number,
+    default: 0
+  }
 })
 
 module.exports = UserProjectSchema
diff --git a/resolvers/index.js b/resolvers/index.js
@@ -1,29 +1,47 @@
 const User = require('../models/User')
 
+const updateHits = require('../utils/updateHits')
+
 const resolvers = {
   Query: {
     getUserById: async (_, { userId }) => {
-      const user = User.findOne({ _id: userId })
-      if (!user) {
-        return null
-      }
+      try {
+        const user = await User.findOne({ _id: userId }).exec()
+        if (!user) {
+          throw new Error(`User with userId ${userId} not found!`)
+        }
 
-      return user
+        return updateHits(user)
+      } catch (e) {
+        throw e
+      }
     },
     getUserByUsername: async (_, { username }) => {
-      const user = await User.findOne({ username })
-      console.log(user)
-      if (!user) {
-        return null
-      }
+      try {
+        const user = await User.findOne({ username }).exec()
+        if (!user) {
+          throw new Error(`User with username ${username} not found!`)
+        }
 
-      return user
+        return updateHits(user)
+      } catch (e) {
+        throw e
+      }
     }
   },
   Mutation: {
     addUser: async (_, { user }) => {
-      const newUser = new User(user)
-      return newUser.save()
+      try {
+        const { username } = user
+        const userExists = await User.countDocuments({ username }).exec()
+        if (userExists) {
+          throw new Error(`A user with the username ${username} already exists`)
+        }
+
+        return new User(user).save()
+      } catch (e) {
+        throw e
+      }
     }
   }
 }
diff --git a/utils/updateHits.js b/utils/updateHits.js
@@ -0,0 +1,15 @@
+async function updateHits (doc) {
+  try {
+    if (!doc.hits) {
+      doc.hits = 1
+    } else {
+      doc.hits += 1
+    }
+
+    return doc.save()
+  } catch (e) {
+    throw e
+  }
+}
+
+module.exports = updateHits
