Do not refetch all the updates when an update is deleted

pbteja1998 · pbteja1998 · commit 535a8af6cfbd · 2021-02-28T10:44:49.000+05:30
diff --git a/src/components/HomePageFeed.tsx b/src/components/HomePageFeed.tsx
@@ -77,13 +77,38 @@ export function HomePageFeedUpdate({
       })
     },
     {
-      onSuccess: () => {
+      onSuccess: (data, variables, context) => {
         toast.success('Deleted your update!!', {
           id: toastId.current,
           icon: <Trash className="text-danger-400" />,
         })
-        queryClient.refetchQueries('/api/fauna/all-updates')
-        queryClient.refetchQueries(['/api/fauna/recent-updates', goal.id])
+
+        if (queryClient.getQueryState('/api/fauna/all-updates')) {
+          queryClient.setQueryData<{ updates: HomePageFeedUpdateType[] }>(
+            '/api/fauna/all-updates',
+            (oldData) => ({
+              updates: oldData.updates.filter(
+                (_update) => _update.id !== update.id
+              ),
+            })
+          )
+        }
+
+        if (queryClient.getQueryState(['/api/fauna/recent-updates', goal.id])) {
+          queryClient.setQueryData<{ response: GoalResponse }>(
+            ['/api/fauna/recent-updates', goal.id],
+            (oldData) => ({
+              response: {
+                ...oldData.response,
+                updates: {
+                  data: oldData.response.updates.data.filter(
+                    (_update) => _update.id !== update.id
+                  ),
+                },
+              },
+            })
+          )
+        }
       },
       onError: () => {
         toast.error('Something went wrong!!!', {
diff --git a/src/components/goals/NewUpdate.tsx b/src/components/goals/NewUpdate.tsx
@@ -74,28 +74,21 @@ export default function NewUpdate({
         )
 
         if (updateFromHomePage) {
-          queryClient.setQueryData<{ updates: HomePageFeedUpdateType[] }>(
-            '/api/fauna/all-updates',
-            (oldData) => {
-              if (!oldData) {
-                return oldData
-              }
-              return {
+          if (queryClient.getQueryState('/api/fauna/all-updates')) {
+            queryClient.setQueryData<{ updates: HomePageFeedUpdateType[] }>(
+              '/api/fauna/all-updates',
+              (oldData) => ({
                 updates: [data.response, ...oldData.updates],
-              }
-            }
-          )
+              })
+            )
+          }
 
-          queryClient.setQueryData<{ response: GoalResponse }>(
-            ['/api/fauna/recent-updates', goal.id],
-            (oldData) => {
-              // If the recent-updates panel is not opened yet
-              // then this oldData will be undefined
-              // since the corresponsing query is not execcuted even once
-              if (!oldData) {
-                return oldData
-              }
-              return {
+          if (
+            queryClient.getQueryState(['/api/fauna/recent-updates', goal.id])
+          ) {
+            queryClient.setQueryData<{ response: GoalResponse }>(
+              ['/api/fauna/recent-updates', goal.id],
+              (oldData) => ({
                 response: {
                   ...oldData.response,
                   updates: {
@@ -110,9 +103,9 @@ export default function NewUpdate({
                     ],
                   },
                 },
-              }
-            }
-          )
+              })
+            )
+          }
         }
 
         reset()
