Disallow defining operators with non-pure functions

cameel · cameel · commit e0722732f6f2 · 2023-01-25T00:29:10.000+01:00
diff --git a/docs/contracts/using-for.rst b/docs/contracts/using-for.rst
@@ -45,7 +45,7 @@ Note that private library functions can only be specified when ``using for`` is
 
 If you define an operator (e.g. ``using {f as +} for T``), then the type (``T``) must be a
 :ref:`user-defined value type <user-defined-value-types>`.
-The definition of an operator must be a function with the types of all parameters and
+The definition of an operator must be a ``pure`` function with the types of all parameters and
 the return value matching ``T``, except for comparison operators, where the return value must
 be of type ``bool``.
 
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp
@@ -4001,6 +4001,13 @@ void TypeChecker::endVisit(UsingForDirective const& _usingFor)
 			}
 			solAssert(usingForType->typeDefinition());
 
+			if (functionType->stateMutability() != StateMutability::Pure)
+				m_errorReporter.typeError(
+					7775_error,
+					path->location(),
+					"Only pure functions can be used to define operators."
+				);
+
 			bool identicalFirstTwoParameters = (parameterCount < 2 || *parameterTypes.at(0) == *parameterTypes.at(1));
 			bool isUnaryOnlyOperator = (!TokenTraits::isBinaryOp(*operator_) && TokenTraits::isUnaryOp(*operator_));
 			bool isBinaryOnlyOperator =
diff --git a/libsolidity/ast/AST.h b/libsolidity/ast/AST.h
@@ -653,7 +653,7 @@ class InheritanceSpecifier: public ASTNode
  * all functions, and this is checked at the point of the using statement. For versions 1 and
  * 2, this check is only done when a function is called.
  *
- * For version 4, T has to be user-defined value type.
+ * For version 4, T has to be user-defined value type and the function must be pure.
  * All parameters and return value of all the functions have to be of type T.
  * This version can be combined with version 3 - a single directive may attach functions to the
  * type and define operators on it at the same time.
diff --git a/test/libsolidity/syntaxTests/operators/userDefined/calling_operator_that_makes_external_call.sol b/test/libsolidity/syntaxTests/operators/userDefined/calling_operator_that_makes_external_call.sol
@@ -21,5 +21,4 @@ contract C {
     }
 }
 // ----
-// test() -> 3
-// gas legacy: 119695
+// TypeError 7775: (27-30): Only pure functions can be used to define operators.
diff --git a/test/libsolidity/syntaxTests/operators/userDefined/implementing_operator_with_non_pure_function.sol b/test/libsolidity/syntaxTests/operators/userDefined/implementing_operator_with_non_pure_function.sol
@@ -0,0 +1,12 @@
+using {add as +, sub as -, mul as *} for A;
+
+function add(A, A) view returns (A) {}
+function sub(A, A) returns (A) {}
+function mul(A, A) payable returns (A) {}
+
+type A is address payable;
+// ----
+// TypeError 7775: (7-10): Only pure functions can be used to define operators.
+// TypeError 7775: (17-20): Only pure functions can be used to define operators.
+// TypeError 7775: (27-30): Only pure functions can be used to define operators.
+// TypeError 9559: (118-159): Free functions cannot be payable.
diff --git a/test/libsolidity/syntaxTests/viewPureChecker/user_operator_with_view_modifier.sol b/test/libsolidity/syntaxTests/viewPureChecker/user_operator_with_view_modifier.sol
diff --git a/test/libsolidity/syntaxTests/viewPureChecker/user_operator_with_view_modifier_can_be_restricted.sol b/test/libsolidity/syntaxTests/viewPureChecker/user_operator_with_view_modifier_can_be_restricted.sol

Original file line number	Diff line number	Diff line change
`@@ -653,7 +653,7 @@ class InheritanceSpecifier: public ASTNode`
`653`	`653`	`* all functions, and this is checked at the point of the using statement. For versions 1 and`
`654`	`654`	`* 2, this check is only done when a function is called.`
`655`	`655`	`*`
`656`		`- * For version 4, T has to be user-defined value type.`
	`656`	`+ * For version 4, T has to be user-defined value type and the function must be pure.`
`657`	`657`	`* All parameters and return value of all the functions have to be of type T.`
`658`	`658`	`* This version can be combined with version 3 - a single directive may attach functions to the`
`659`	`659`	`* type and define operators on it at the same time.`
Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,4 @@ contract C {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`	`// ----`
`24`		`-// test() -> 3`
`25`		`-// gas legacy: 119695`
	`24`	`+// TypeError 7775: (27-30): Only pure functions can be used to define operators.`