fix: add nx to peer deps for now

Chau Tran · Chau Tran · commit 00ab36a1f663 · 2023-05-05T22:46:10.000-05:00
diff --git a/libs/angular-three/ng-package.json b/libs/angular-three/ng-package.json
@@ -4,6 +4,6 @@
     "lib": {
         "entryFile": "src/index.ts"
     },
-    "allowedNonPeerDependencies": ["ngx-resize", "@rx-angular/state", "@nx/devkit"],
+    "allowedNonPeerDependencies": ["ngx-resize", "@rx-angular/state", "@nx/devkit", "nx"],
     "assets": ["metadata.json", "web-types.json"]
 }
diff --git a/libs/angular-three/package.json b/libs/angular-three/package.json
@@ -29,7 +29,8 @@
         "ngx-resize": "^1.0.0",
         "@rx-angular/state": "^14.0.0",
         "tslib": "^2.3.0",
-        "@nx/devkit": "^16.1.0"
+        "@nx/devkit": "^16.0.0",
+        "nx": "^16.0.0"
     },
     "sideEffects": false,
     "generators": "./plugin/generators.json",
diff --git a/libs/plugin/src/generators/init/init.ts b/libs/plugin/src/generators/init/init.ts
@@ -37,7 +37,7 @@ export default async function (tree: Tree) {
 
     // add metadata.json to vscode settings if exists
     const vscodeSettingsPath = '.vscode/settings.json';
-    if (tree.exists(vscodeSettingsPath)) {
+    if (tree.exists('.vscode') || tree.exists(vscodeSettingsPath)) {
         logger.info('Enabling typings support for VSCode...');
         updateJson(tree, vscodeSettingsPath, (json) => {
             if (json['html.customData'] && Array.isArray(json['html.customData'])) {
@@ -48,7 +48,15 @@ export default async function (tree: Tree) {
 
             return json;
         });
+    } else {
+        logger.info(
+            `.vscode/settings.json not found.
+If you are using VSCode, add "./node_modules/angular-three/metadata.json" to "html.customData" in ".vscode/settings.json"
+to enable TypeScript type definitions for Angular Three elements.
+`
+        );
     }
+
     return () => {
         installPackagesTask(tree);
     };

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"lib": {`
`5`	`5`	`"entryFile": "src/index.ts"`
`6`	`6`	`},`
`7`		`- "allowedNonPeerDependencies": ["ngx-resize", "@rx-angular/state", "@nx/devkit"],`
	`7`	`+ "allowedNonPeerDependencies": ["ngx-resize", "@rx-angular/state", "@nx/devkit", "nx"],`
`8`	`8`	`"assets": ["metadata.json", "web-types.json"]`
`9`	`9`	`}`