Fixes slow CSV exports

hanophora · hanophora · commit ef9955598bed · 2019-10-05T19:35:55.000+02:00
For each split in every exported transaction, the code fetched the whole
Account instance, including all its transactions with all their splits.
This resulted in hundreds of thousands of requests with a medium-sized
ledger.

There was a cache mechanism, but it was local to one single transaction,
thus essentially useless.

Now, each split generates two requests, to get the account's name and
full name. A better cache mechanism would speed this up further.
diff --git a/app/src/main/java/org/gnucash/android/export/csv/CsvTransactionsExporter.java b/app/src/main/java/org/gnucash/android/export/csv/CsvTransactionsExporter.java
@@ -99,27 +99,16 @@ public List<String> generateExport() throws ExporterException {
     private void writeSplitsToCsv(@NonNull List<Split> splits, @NonNull CsvWriter writer) throws IOException {
         int index = 0;
 
-        Map<String, Account> uidAccountMap = new HashMap<>();
-
         for (Split split : splits) {
             if (index++ > 0){ // the first split is on the same line as the transactions. But after that, we
                 writer.write("" + mCsvSeparator + mCsvSeparator + mCsvSeparator + mCsvSeparator
                         + mCsvSeparator + mCsvSeparator + mCsvSeparator + mCsvSeparator);
             }
             writer.writeToken(split.getMemo());
 
-            //cache accounts so that we do not have to go to the DB each time
             String accountUID = split.getAccountUID();
-            Account account;
-            if (uidAccountMap.containsKey(accountUID)) {
-                account = uidAccountMap.get(accountUID);
-            } else {
-                account = mAccountsDbAdapter.getRecord(accountUID);
-                uidAccountMap.put(accountUID, account);
-            }
-
-            writer.writeToken(account.getFullName());
-            writer.writeToken(account.getName());
+            writer.writeToken(mAccountsDbAdapter.getAccountFullName(accountUID));
+            writer.writeToken(mAccountsDbAdapter.getAccountName(accountUID));
 
             String sign = split.getType() == TransactionType.CREDIT ? "-" : "";
             writer.writeToken(sign + split.getQuantity().formattedString());
