Fix slide position overriding when it shouldn't (AttorneyOnline#1023)

TrickyLeifa · web-flow · commit 4129c1ffda6e · 2024-07-19T13:20:21.000+02:00
* Fix slide position overriding when it shouldn't

* Cover all positions instead
diff --git a/src/path_functions.cpp b/src/path_functions.cpp
@@ -82,18 +82,14 @@ BackgroundPosition AOApplication::get_pos_path(const QString &pos)
 {
   // witness is default if pos is invalid
   QString f_pos = pos;
+
   // legacy overrides for new format if found
-  if (pos == "def" && file_exists(get_image_suffix(get_background_path("court"))))
-  {
-    f_pos = "court:def";
-  }
-  else if (pos == "pro" && file_exists(get_image_suffix(get_background_path("court"))))
+  if (file_exists(get_image_suffix(get_background_path("court"))))
   {
-    f_pos = "court:pro";
-  }
-  else if (pos == "wit" && file_exists(get_image_suffix(get_background_path("court"))))
-  {
-    f_pos = "court:wit";
+    if (!read_design_ini("court:" + f_pos + "/origin", get_background_path("design.ini")).isEmpty())
+    {
+      f_pos = QString("court:%1").arg(f_pos);
+    }
   }
   QStringList f_pos_split = f_pos.split(":");
 
