-
-
Notifications
You must be signed in to change notification settings - Fork 280
remove coloring from pre-commit prints #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting! if my memory serves me right, we did not do anything to disable the color 🤔 might need to take a look at the pre-commit side as well |
Finally took the time to dive into this one: That's actually quite simple and it's definitely coming from here. Going upstream from If Now the question is: should the ANSI colorisation be authorized in the |
Hi @12rambau Thanks for your help! Does that mean if we keep the ANSI coloring, we might break platform compatibility? If that's the case, I'd say platform compatibility is way more important. |
Agreed. Then I'll check if it can be set somewhere in the documentation in a note and then I'll close this issue |
@12rambau Great! Thanks for your help! |
Description
I use the pre-commit framework to apply some sanity check before committing to my repositories. I recently discover this lib and wanted to give it a try. Fantastic work !
I use te following command to create a new commit:
And I get the following results (sorry for the image but everything is about coloring):

after
#258
which is the commit message, the pre-commit checks start and normally at the end of their linesskipped
should be blue,passed
: green andfailed
red. when creating a commit withcz
I loose these colors. I tested back using simplygit commit
and it worked.Question then: why is the coloring of
pre-commit
disabled bycz
?The text was updated successfully, but these errors were encountered: